designate-manage pool show_config command broken

Bug #1459433 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Tim Simmons

Bug Description

https://github.com/openstack/designate/commit/8662fe52cdeeaad7908487cd414fe2a239397d71#diff-0a9143090a2b3a159920107fc44cbeebR78

changed the number of parameters to objects.Pool.from_config

`designate-manage pool show_config` calls this directly, but with the incorrect number of arguments now.

****************************************************************************************************
Pool Configuration:
****************************************************************************************************
2015-05-27 20:56:17.680 CRITICAL designate [designate-manage - - - - -] TypeError: from_config() takes exactly 3 arguments (2 given)

2015-05-27 20:56:17.680 18290 TRACE designate Traceback (most recent call last):
2015-05-27 20:56:17.680 18290 TRACE designate File "/usr/local/bin/designate-manage", line 10, in <module>
2015-05-27 20:56:17.680 18290 TRACE designate sys.exit(main())
2015-05-27 20:56:17.680 18290 TRACE designate File "/home/vagrant/dez/designate/designate/cmd/manage.py", line 126, in main
2015-05-27 20:56:17.680 18290 TRACE designate fn(*fn_args)
2015-05-27 20:56:17.680 18290 TRACE designate File "/home/vagrant/dez/designate/designate/manage/pool.py", line 33, in show_config
2015-05-27 20:56:17.680 18290 TRACE designate pprint.pprint(objects.Pool.from_config(CONF).to_dict())
2015-05-27 20:56:17.680 18290 TRACE designate TypeError: from_config() takes exactly 3 arguments (2 given)
2015-05-27 20:56:17.680 18290 TRACE designate

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/186164

Changed in designate:
assignee: nobody → Tim Simmons (tim-simmons-t)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/186164
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=c254d12ccc934884cd28848eac33d492f4a86141
Submitter: Jenkins
Branch: master

commit c254d12ccc934884cd28848eac33d492f4a86141
Author: Tim Simmons <email address hidden>
Date: Wed May 27 20:56:00 2015 +0000

    Fix designate-manage pool show_config command

    * Add an optional pool_id argument to the show_config pool helper command
    * Remove a hardcoded reference to the default pool ID

    Change-Id: Ica99c8761157202ec0e9f37706d75584e7bc1b03
    Closes-Bug: 1459433

Changed in designate:
status: In Progress → Fix Committed
Kiall Mac Innes (kiall)
Changed in designate:
importance: Undecided → High
milestone: none → liberty-1
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.