designate-api Throws Error on stop()

Bug #1442141 reported by Graham Hayes
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Erik Olof Gunnar Andersson

Bug Description

2015-04-09 14:06:18.464 ERROR designate.openstack.common.threadgroup [-] Calling waitall() from within one of the GreenPool's greenthreads will never terminate.
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup Traceback (most recent call last):
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/designate/openstack/common/threadgroup.py", line 98, in _stop_threads
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup x.stop()
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/designate/openstack/common/threadgroup.py", line 44, in stop
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup self.thread.kill()
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/.venv/local/lib/python2.7/site-packages/eventlet/greenthread.py", line 240, in kill
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup return kill(self, *throw_args)
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/.venv/local/lib/python2.7/site-packages/eventlet/greenthread.py", line 294, in kill
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup g.throw(*throw_args)
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/.venv/local/lib/python2.7/site-packages/eventlet/greenthread.py", line 214, in main
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup result = function(*args, **kwargs)
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/designate/service.py", line 225, in _wsgi_handle
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup log=loggers.WritableLogger(logger))
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/.venv/local/lib/python2.7/site-packages/eventlet/wsgi.py", line 816, in server
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup pool.waitall()
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup File "/home/graham/repos/github/openstack/designate/.venv/local/lib/python2.7/site-packages/eventlet/greenpool.py", line 117, in waitall
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup "Calling waitall() from within one of the " \
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup AssertionError: Calling waitall() from within one of the GreenPool's greenthreads will never terminate.
2015-04-09 14:06:18.464 TRACE designate.openstack.common.threadgroup

Changed in designate:
assignee: nobody → Graham Hayes (grahamhayes)
Kiall Mac Innes (kiall)
tags: added: kilo-rc-potential
Revision history for this message
Tim Simmons (timsim) wrote :
tags: removed: kilo-rc-potential
Changed in designate:
milestone: none → liberty-1
importance: Undecided → Medium
status: New → Triaged
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-1 → liberty-2
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-2 → liberty-3
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-3 → liberty-rc1
Kiall Mac Innes (kiall)
Changed in designate:
milestone: liberty-rc1 → none
Changed in designate:
assignee: Graham Hayes (grahamhayes) → nobody
Changed in designate:
assignee: nobody → Erik Olof Gunnar Andersson (eandersson)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/678432
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=a09064a5d15859703b97d61a1f014681a17799c6
Submitter: Zuul
Branch: master

commit a09064a5d15859703b97d61a1f014681a17799c6
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Sun Aug 25 11:13:32 2019 -0700

    Refactored service layer

    Service layer has been simplified by removing abstraction
    and making the implementation more in line with other
    OpenStack projects.

    Moved Heartbeat code out of Service class and
    into the console scripts. We only need one instance
    of the Heartbeat Emitter.

    Cleaned up the WSGI code by making use of the
    reusable oslo_service.wsgi code.

    * Added Heartbeat to designate-sink.
    * Cleaned up and refactored Service layers.
    * Fixed various bugs e.g. errors on shutdown.
    * Removed deprecated options host, port etc.
    * Simplified Heartbeat implementation.

    Closes-Bug: #1442141
    Change-Id: I536b92407bf6ca5bddf4c048909cd13d4e094d26

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 9.0.0.0rc1

This issue was fixed in the openstack/designate 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers