Requires jsonschema >= 2.4.0 (not 2.2.0)

Bug #1436261 reported by James Page
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Critical
Graham Hayes

Bug Description

Detected during kilo-3 updates in Ubuntu vivid (jsonschema 2.3.0):

Traceback (most recent call last):
  File "designate/tests/test_objects/test_base.py", line 368, in test_validate_recursive
    obj.validate()
  File "designate/objects/base.py", line 302, in validate
    errors.append(ValidationError.from_js_error(error))
  File "designate/objects/validation_error.py", line 33, in from_js_error
    e.relative_path = js_error.relative_path
AttributeError: 'ValidationError' object has no attribute 'relative_path'

relative_path was introduced in 2.4.0:

https://github.com/Julian/jsonschema/commit/44b35706a7476fb42ac47520860b63aeebfe39e5

Kiall Mac Innes (kiall)
Changed in designate:
importance: Undecided → Critical
milestone: none → kilo-rc1
assignee: nobody → Graham Hayes (grahamhayes)
status: New → Won't Fix
status: Won't Fix → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167570

Changed in designate:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/167570
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=2709bd7187c0758c3a2113b5cb8dc6e4cf0d7b82
Submitter: Jenkins
Branch: master

commit 2709bd7187c0758c3a2113b5cb8dc6e4cf0d7b82
Author: Graham Hayes <email address hidden>
Date: Wed Mar 25 11:54:42 2015 +0000

    Remove usage of relative_path in ValidationError Objects

    * 'relative_path' requires JSONSchema 2.4.0
    * Defaults to trying 'relative_path' and falls back to 'path'

    Change-Id: Ie8902a3b943ea4e631155ae208aed9d3911c9767
    Closes-Bug: #1436261

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.