The pool manager cache doesn't actually use memcached

[Eric Larson]

In looking into `designate.pool_manager.cache.impl_memcache.__init__.py` there is no reference to a memcached client. Upon closer inspection, it uses `designate.openstack.common.memorycache`, which is a simple local, fake, client.

This in memory cache could work on a per-node basis. But, if we are going to support this kind of functionality, we should be sure the client is actually threadsafe by adding some locks around the set/delete operations.

Beyond this though, we should be sure that if we have an actual memcached server defined, that server is used. We can also confirm the memcached cilent is threadsafe or uses a thread pool.

[Eric Larson (eric-larson)]

It looks like I was wrong:

  https://github.com/openstack/designate/blob/master/designate/openstack/common/memorycache.py#L44

Should memcache be a requirement or extra_requires?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/159535

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/159535
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=45ac275539ccaf7e4853a26fdcec6e1f6ecc10bb
Submitter: Jenkins
Branch: master

commit 45ac275539ccaf7e4853a26fdcec6e1f6ecc10bb
Author: Eric Larson <email address hidden>
Date: Thu Feb 26 16:38:43 2015 +0000

    Add python-memcached>=1.48 to requirements.txt

    Change-Id: I4f0c2ee57ceabaac873cec06ad49082eab8cb1f8
    Closes-Bug: 1425726