Nameservers added via /v2/pools are not validated

Bug #1419138 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Tim Simmons

Bug Description

Nameservers in the /v2/pools API can be passed without being proper hostnames.

PATCH /v2/pools/id

{
  "pool":{
    "nameservers":[
      "ns1.test.com",
      "ns2.test.com"
      ]
  }
}

Will work just fine when there should be a trailing dot.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/153676

Changed in designate:
assignee: nobody → Tim Simmons (tim-simmons-t)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/153676
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=32e75e1856cedf4d4a0d5e54f345c5eee25fd435
Submitter: Jenkins
Branch: master

commit 32e75e1856cedf4d4a0d5e54f345c5eee25fd435
Author: Tim Simmons <email address hidden>
Date: Fri Feb 6 20:21:49 2015 +0000

    Nameservers added via /v2/pools are not validated

    Use the correct validator for hostname to prevent nameservers with
    improper hostnames from getting to the database.

    Change-Id: I21852c7904c5aa824cd76f65a6d8c78c3fa72c64
    Closes-Bug: 1419138

Changed in designate:
status: In Progress → Fix Committed
Changed in designate:
importance: Undecided → High
milestone: none → kilo-3
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.