API v1 listing of records noticibly slower moving to Juno

Bug #1413472 reported by Sam Morrison
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Graham Hayes

Bug Description

Doing:
time designate record-list XXXX-XXXX-XXXX-XXXXX

With a domain with 100 records:

Icehouse:
real 0m0.842s
user 0m0.320s
sys 0m0.046s

Juno:
real 0m1.574s
user 0m0.348s
sys 0m0.031s

With a domain with 1000 records:

Icehouse:
real 0m3.263s
user 0m1.576s
sys 0m0.067s

Juno:
real 0m9.180s
user 0m1.574s
sys 0m0.042s

I can see this is due to the code in storage/impl_sqlalchemy/__init__.py:find_recordsets

first it gets all record sets then does a for loop over them and does another sql query. I wonder if this query could be made more efficient by using one query and a join?

Kiall Mac Innes (kiall)
Changed in designate:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → kilo-2
Kiall Mac Innes (kiall)
Changed in designate:
milestone: kilo-2 → kilo-3
Kiall Mac Innes (kiall)
Changed in designate:
milestone: kilo-3 → kilo-rc1
Kiall Mac Innes (kiall)
Changed in designate:
importance: Medium → High
Kiall Mac Innes (kiall)
summary: - Listing records noticibly slower moving to Juno
+ API v1 listing of records noticibly slower moving to Juno
Kiall Mac Innes (kiall)
Changed in designate:
assignee: nobody → Graham Hayes (grahamhayes)
Kiall Mac Innes (kiall)
Changed in designate:
milestone: kilo-rc1 → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172415

Changed in designate:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/172415
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=a009d30a580b26d9e103ca29fddaa481f544f7db
Submitter: Jenkins
Branch: master

commit a009d30a580b26d9e103ca29fddaa481f544f7db
Author: Graham Hayes <email address hidden>
Date: Fri Apr 10 14:19:24 2015 +0100

    Moved RecordSet lookup to a custom join query

    * New function, to get all RRsets + Records in one go.

    Change-Id: I562acb1edbae0e92cbb54d290b1a4f37bd672b2a
    Closes-Bug: #1413472

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.