Service Fixture in Unit Tests Does not Stop Service

[Ron Rickard]

The Service Fixture in unit tests is not actually stopping the service. An exception is being thrown (and ignored) in the code. We are calling the Service.kill method but there is no kill method. There is a stop method.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/300513

[Eric Larson (eric-larson)]

This breaks the tests pretty badly. I'm guessing that now the actual service is stopped, that other tests actually needed it up everything fails.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/300513
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=ed51f49a90fe9884de1ecd60ea490407b8f5d145
Submitter: Jenkins
Branch: master

commit ed51f49a90fe9884de1ecd60ea490407b8f5d145
Author: Kiall Mac Innes <email address hidden>
Date: Mon May 16 13:26:18 2016 +0100

    Ensure services shutdown during unit testing

    * Use stop() instead of kill() in Service fixture.
    * Add reset() methods to each rpcapi, and call them after
      shutting down services, allowing for the above to work.

    Change-Id: I90a1d9c40fc7f60864cfbfc7c9e47429405bc32c
    Closes-Bug: 1411717

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/designate 3.0.0.0b1 development milestone.