DynECT backend fails to catch certain failures during zone creation

[Kiall Mac Innes]

Caused in this case by setting the masters to a IP:PORT combo, which DynECT doesn't support - See logs:

2014-12-03 21:19:57.011 DEBUG designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] REQ: curl -i -X 'POST' 'https://api.dynect.net:443/REST/Secondary/devstack-test-1.com' -H 'Auth-Token: *******' from (pid=8184) _http_log_req /opt/stack/designate/designate/backend/impl_dynect.py:171
2014-12-03 21:19:57.011 DEBUG designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] REQ BODY: {'masters': ['87.192.80.196:5354']}
 from (pid=8184) _http_log_req /opt/stack/designate/designate/backend/impl_dynect.py:173
2014-12-03 21:19:57.012 DEBUG urllib3.connectionpool [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] Setting read timeout to 10 from (pid=8184) _make_request /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:375
2014-12-03 21:19:57.884 DEBUG urllib3.connectionpool [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] "POST /REST/Secondary/devstack-test-1.com HTTP/1.1" 400 None from (pid=8184) _make_request /usr/lib/python2.7/dist-packages/urllib3/connectionpool.py:415
2014-12-03 21:19:57.885 DEBUG designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] RESP: [400] CaseInsensitiveDict({'date': 'Wed, 03 Dec 2014 21:19:57 GMT', 'transfer-encoding': 'chunked', 'connection': 'keep-alive', 'content-type': 'application/json', 'server': 'nginx/1.2.6'})
 from (pid=8184) _http_log_resp /opt/stack/designate/designate/backend/impl_dynect.py:179
2014-12-03 21:19:57.886 DEBUG designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] RESP BODY: {"status": "failure", "data": {}, "job_id": 1326038394, "msgs": [{"INFO": "master: IP address expected", "SOURCE": "DYN", "ERR_CD": "INVALID_DATA", "LVL": "ERROR"}, {"INFO": "create: Zone not created", "SOURCE": "BLL", "ERR_CD": null, "LVL": "INFO"}]}
2014-12-03 21:19:57.886 DEBUG designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] Request returned failure status: 400 from (pid=8184) _request /opt/stack/designate/designate/backend/impl_dynect.py:239
2014-12-03 21:19:57.887 INFO designate.backend.impl_dynect [req-c6d4b31c-3821-4c2b-872b-05166a2f6daa a27f7ce25b8848ee856b42fc71e527db 0d1f2cf70e1649ab923e4b356c55a7c3] Domain already exists, updating existing domain instead devstack-test-1.com.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/141291

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/142757

[OpenStack Infra (hudson-openstack)]

Change abandoned by Endre Karlson (<email address hidden>) on branch: master
Review: https://review.openstack.org/142757

[OpenStack Infra (hudson-openstack)]

Change abandoned by Endre Karlson (<email address hidden>) on branch: master
Review: https://review.openstack.org/141291

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168588
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=55de27b95ae7d8544db5cfb314e2ea8169b06c55
Submitter: Jenkins
Branch: master

commit 55de27b95ae7d8544db5cfb314e2ea8169b06c55
Author: Kiall Mac Innes <email address hidden>
Date: Sat Mar 28 15:11:53 2015 +0000

    DynECT: Convert to a Pool Backend

    Change-Id: Ia68020563274f5b7854db5d5a586641f07b266a7
    Closes-Bug: 1404529
    Closes-Bug: 1398989