Sample Sink Handlers can delete ALL records in a zone

[Kiall Mac Innes]

Sample Sink Handlers can delete ALL records in a zone by mistake, if managed=False is passed to the BaseAddressHandler's _delete method.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/158690

[Graham Hayes (grahamhayes)]

The code base does not give an option here - our solution is to deprecate the managed=False option. This cannot be back ported, as it would be too much of a change.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158690
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=237c052f47dc34a02cb130fd602ff369834dd11f
Submitter: Jenkins
Branch: master

commit 237c052f47dc34a02cb130fd602ff369834dd11f
Author: Graham Hayes <email address hidden>
Date: Tue Feb 24 13:39:09 2015 +0000

    Deprecate designate-sink non managed mode

    This inserts a deprecation notice for notification_handler plugins
    that use the _create and _delete calls with "managed=False"

    Change-Id: I62906c88a0b0f27007ec45cfdd73ac3e199c152c
    Closes-Bug: 1387662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/584619
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=116b202d1815b1e0fdcf6a2c7e940b85bcedda06
Submitter: Zuul
Branch: master

commit 116b202d1815b1e0fdcf6a2c7e940b85bcedda06
Author: Erik Olof Gunnar Andersson <email address hidden>
Date: Sat Jul 21 23:17:09 2018 -0700

    Removed deprecated managed option in notification handler

    The managed option has been deprecated for 3 years now, and is
    risky in general as it can cause custom sink handlers to delete
    all records in a zone by mistake.

    This also allows us to clean the code path up a bit.

    Related-Bug: #1387662
    Change-Id: Id6174eb7df0c7bc9d138e74f72b6931a025ec818