Storage's find_tenants method signature differs from the other find_* methods

Bug #1281128 reported by Kiall Mac Innes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Won't Fix
Low
Unassigned

Bug Description

Storage's find_tenants method signature differs from the other find_* methods.

e.g.:

def find_tenants(self, context):
https://github.com/stackforge/designate/blob/master/designate/storage/base.py#L155

vs

def find_domains(self, context, criterion=None):
https://github.com/stackforge/designate/blob/master/designate/storage/impl_sqlalchemy/__init__.py#L246

Kiall Mac Innes (kiall)
Changed in designate:
status: New → Triaged
importance: Undecided → Wishlist
description: updated
description: updated
Changed in designate:
importance: Wishlist → Low
Changed in designate:
assignee: nobody → Endre Karlson (endre-karlson)
Changed in designate:
assignee: Endre Karlson (endre-karlson) → nobody
tags: added: low-hanging-fruit
Changed in designate:
assignee: nobody → Sharat Sharma (sharat-sharma)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/309977

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/309977

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320511

Changed in designate:
status: In Progress → New
assignee: Sharat Sharma (sharat-sharma) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (master)

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/320511

Tim Simmons (timsim)
Changed in designate:
status: New → Confirmed
Revision history for this message
Graham Hayes (grahamhayes) wrote :

This has been open for a long period of time, with a low priority.

As a result, I am closing the bug.

If you feel this was in error, and this is important please re-open, and feel free to start working on the bug.

Changed in designate:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.