Support multiple database connections in the SQLAlchemy storage implementation

Bug #1074093 reported by Kiall Mac Innes
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Kiall Mac Innes

Bug Description

Support multiple database connections in the SQLAlchemy storage implementation, this will allow for connections to additional databases e.g. PowerDNS.

The current use of global _ENGINE and _MAKER variables in session.py prevents this.

At the same time - we should continue to support multiple sessions on a single engine.

Changed in moniker:
milestone: none → grizzly-1
assignee: nobody → Endre Karlson (endre-karlson)
importance: Undecided → Wishlist
status: New → In Progress
milestone: grizzly-1 → none
assignee: Endre Karlson (endre-karlson) → nobody
importance: Wishlist → Undecided
status: In Progress → New
Kiall Mac Innes (kiall)
Changed in moniker:
milestone: none → grizzly-2
Changed in moniker:
assignee: nobody → JC Martin (jemartin)
importance: Undecided → Medium
Revision history for this message
JC Martin (jemartin) wrote :

Since Moniker and the backend might use different engines, it seems that the goal is more to provide a generic SQLAlchemy library to facilitate backend development.
This would allow each implementation to have its own engine, and each engine have multiple sessions.
In addition, the configuration related to SQLAlchemy should provide a kind of name space to allow the configuration of each engine independently

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to moniker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17103

Changed in moniker:
status: New → In Progress
Kiall Mac Innes (kiall)
Changed in moniker:
milestone: grizzly-2 → grizzly-1
Changed in moniker:
assignee: JC Martin (jemartin) → Kiall Mac Innes (kiall)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to moniker (master)

Reviewed: https://review.openstack.org/17103
Committed: http://github.com/stackforge/moniker/commit/f8df098d3059d6a9c58395348eb876394d825fe4
Submitter: Jenkins
Branch: master

commit f8df098d3059d6a9c58395348eb876394d825fe4
Author: JC Martin <email address hidden>
Date: Mon Dec 3 14:04:52 2012 -0800

    Partial fix for bug #1074093

    engine and makers are stored in dictionnary in the
    sqlalchemy/session.py

    Change-Id: Ied2c13e9ed7117730eccc8db4c3a03b54c66d4b9

Changed in moniker:
status: In Progress → Fix Committed
Kiall Mac Innes (kiall)
Changed in designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.