[patch] updates for NetworkManager 0.9

Bug #752969 reported by Dan Williams
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Déjà Dup
Fix Released
High
Unassigned
18
Fix Released
High
Unassigned

Bug Description

NM 0.9 updates connection states to be slightly more detailed, and they are renumbered so that dbus clients can seamlessly retain backwards compatibility with older versions of NM.

Revision history for this message
Dan Williams (dcbw) wrote :
Revision history for this message
Michael Terry (mterry) wrote :

Does this mean that old state numbers don't work? i.e. is NM 0.9 not backwards compatible with older dbus clients?

Revision history for this message
Michael Terry (mterry) wrote :

Thanks for the patch!

Changed in deja-dup:
importance: Undecided → High
milestone: none → 19.0
status: New → Fix Committed
Revision history for this message
Michael Terry (mterry) wrote :

Note that if you're applying this in Fedora like it seems you are, there was one more instance of NM_STATE_CONNECTED that had to be cleaned up in that file:

=== modified file 'common/Network.vala'
--- common/Network.vala 2011-04-06 22:11:14 +0000
+++ common/Network.vala 2011-04-06 23:29:54 +0000
@@ -112,7 +112,14 @@
     if (signal_name == "StateChanged") {
       uint32 state;
       parameters.get("(u)", out state);
- update_status(state == NM_STATE_CONNECTED ? Status.ONLINE : Status.OFFLIN
+
+ if (state == NM_OLD_STATE_CONNECTED ||
+ state == NM_STATE_CONNECTED_LOCAL ||
+ state == NM_STATE_CONNECTED_SITE ||
+ state == NM_STATE_CONNECTED_GLOBAL)
+ update_status(Status.ONLINE);
+ else
+ update_status(Status.OFFLINE);
     }
   }
 }

Michael Terry (mterry)
Changed in deja-dup:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.