Don't run monitor when no backup is configured

[Hans Wolters]

It seems Deja is already running while there is nothing configured. I would advise to start a dry run if a target backup location is known, or even when a selection is known. This is just using resources when it's not needed.

[Hans Wolters (hans-wolters-nlo)]

Another addition. If people deinstall deja the monitoring process is not killed/stopped.

[Michael Terry (mterry)]

I understand why this is not ideal, but deja-dup-monitor nowadays does more than just kick off backups. It also keeps track of prompting the user to consider backing up after a month of not configuring one. And in the future might prompt the user to use a plugged in external drive for backups.

So it's hard to fit all that into into one preference such that gnome-session can manage the monitor's lifetime based on the gsettings key.

I've tried to keep the monitor's footprint small (keeping most of the actual work in other executables and making sure we don't link to gtk).

I'm very tempted to mark this Won't Fix, but I'll leave it open because I do recognize that it would be swell to not run this if the user just doesn't care about backups at all. But I suppose they could uninstall it then.

As for your comment about not shutting down when uninstalled, that is common behavior. If you are running a application, it won't close if you uninstall it. Not sure we should do anything about that.

[Hans Wolters (hans-wolters-nlo)]

Hi,

Thanks for the answer. I understand why it was done this way but I do not understand why this would be a problem. If no backup is configured there is no need to poll a.f.a.i.k. I do see that the poller is not very expensive.

As for the shutdown once people uninstall it, I think it would be a good practice. You don't want software to keep running if it might lack module it needs to load (not sure if this is the case here). Just my opinion.

Best regards,

Hans

[Michael Terry (mterry)]

This was finally done in 38.4 I believe.