[PATCH] add GTK requirement to some modules

Bug #632612 reported by Luis Medinas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Déjà Dup
Fix Released
Critical
Michael Terry

Bug Description

I packaged deja-dup for openSUSE (btw... it will be on 11.4 and it's available on GNOME repositories already) and the build service complained about missing GTK+ dependency when building common and monitor modules.
The check was right and in fact deja-dup requires GTK+ to build these modules.
The attached patch fixes this issue.

Revision history for this message
Luis Medinas (lmedinas) wrote :
Revision history for this message
Michael Terry (mterry) wrote :

Thanks for the report! And thank you for packaging it for openSUSE!

Those modules shouldn't require GTK though... I would consider it a bug that they do, not a bug that configure doesn't add the modules. That should be a fine patch to get you past the hump, but I'd like to investigate what symbols were required from GTK.

Can you link me to a failed build log?

Revision history for this message
Luis Medinas (lmedinas) wrote :

Well the problem is a bit more complicated, the build fails because of libnotify since it doesn't require GTK+ itself. libnotify 0.5.1 doesn't use any specific gtk version (2 or 3) so deja-dup is using libnotify to use the right headers (gtk.h).
See http://bugzilla.novell.com/show_bug.cgi?id=626455 for more information.

Revision history for this message
Michael Terry (mterry) wrote :

Ick. I understand now. I think this is a poor decision on libnotify's maintainers end. They should provide libnotify and libnotify3 bindings. Oh well. I'll fix this in trunk.

Changed in deja-dup:
assignee: nobody → Michael Terry (mterry)
importance: Undecided → Critical
status: New → Fix Committed
Michael Terry (mterry)
Changed in deja-dup:
milestone: none → 15.92
Michael Terry (mterry)
Changed in deja-dup:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.