Use folder-remote icon for S3

[Michael Monreal]

"Amazon S3" is currently displayed as a normal folder in the file chooser. Would be better to use "folder-remote" or maybe even the web category icon, as the normal folder usually means "local".

[Michael Terry (mterry)]

Agreed. The issue is that GtkFileChooserButton doesn't really allow us to add 'special/custom' options to it. Everything must be a GIO path. Since Amazon S3 isn't a GIO path, Deja Dup does a really gross hack to make the option "Amazon S3" appear (basically, it creates a directory in /tmp/XXX named "Amazon S3" and points to it). We can't control the icon when doing this hack.

A long time ago, I me-too'd an enhancement request against GTK+ to add such 'special' option support to the button. No action for a long time. I've added that bug to this bug for tracking purposes.

A separate way of solving this bug for Deja Dup would be to find a way to set custom icons for normal folders. I don't believe GIO will let you set that GFileInfo attribute yet.

[Michael Terry (mterry)]

As a note, it would probably be better to use an Amazon S3 specific icon if we can (don't know if an S3 logo icon would be distributable).

[Michael Terry (mterry)]

Fixed in 17.4.