Does not compile with -DGSEAL_ENABLE

[Andre Klapper]

deja-dup-14.0.2 tarball does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal .
This is required for upcoming GNOME 3.0.

[Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see GNOME Bugzilla bugs 588389 and 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.]

The output posted here of course only lists the very first error when trying to compile:

ConfigLocation.c: In function ‘deja_dup_config_location_constructor’:
ConfigLocation.c:649: error: ‘GtkDialog’ has no member named ‘action_area’
make[3]: *** [ConfigLocation.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/deja-dup-14.0.2/widgets'
make[2]: *** [all] Error 2

[Michael Terry (mterry)]

While this report is valid, it has more to do with valac, which generates code that is not gseal-compliant. We'll have to wait for valac to be fixed.

[Andre Klapper (a9016009)]

Is there a bug report for valac to track (URL)?
If not, please file one.

[Javier Jardón (jjardon)]

Filled a bug in vala bugzilla here: https://bugzilla.gnome.org/show_bug.cgi?id=616127

[Javier Jardón (jjardon)]

@Michael:

From the upstream bug report:

"deja-dup should use get_action_area() rather than accessing the field, it's not
up to the compiler to generate or not gseal-compliant code.
VAPI should use the new has_separator property and remove the public fields."

[Michael Terry (mterry)]

I've made the current code base GSEAL compatible. The one function unable to be ported is Gtk.Widget's is_toplevel, which gtk+-2.0.vapi still translates into GTK_WIDGET_TOPLEVEL. When we use gtk+-3.0.vapi, that will be fixed. But for the moment, I commented out the additional check (which should be harmless in practice). So we're good for now.