Déjà Dup Backup Tool

Does not compile with -DGSEAL_ENABLE

Reported by Andre Klapper on 2010-04-15
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Déjà Dup
Low
Michael Terry
Vala
Fix Released
Medium

Bug Description

deja-dup-14.0.2 tarball does not build with -DGSEAL_ENABLE. See http://live.gnome.org/GnomeGoals/UseGseal .
This is required for upcoming GNOME 3.0.

[Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see GNOME Bugzilla bugs 588389 and 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.]

The output posted here of course only lists the very first error when trying to compile:

ConfigLocation.c: In function ‘deja_dup_config_location_constructor’:
ConfigLocation.c:649: error: ‘GtkDialog’ has no member named ‘action_area’
make[3]: *** [ConfigLocation.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/deja-dup-14.0.2/widgets'
make[2]: *** [all] Error 2

Michael Terry (mterry) wrote :

While this report is valid, it has more to do with valac, which generates code that is not gseal-compliant. We'll have to wait for valac to be fixed.

Changed in deja-dup:
importance: Undecided → Low
status: New → Confirmed
Andre Klapper (a9016009) wrote :

Is there a bug report for valac to track (URL)?
If not, please file one.

Javier Jardón (jjardon) wrote :

Filled a bug in vala bugzilla here: https://bugzilla.gnome.org/show_bug.cgi?id=616127

Changed in vala:
status: Unknown → New
Changed in vala:
status: New → Confirmed
Javier Jardón (jjardon) wrote :

@Michael:

From the upstream bug report:

"deja-dup should use get_action_area() rather than accessing the field, it's not
up to the compiler to generate or not gseal-compliant code.
VAPI should use the new has_separator property and remove the public fields."

Michael Terry (mterry) wrote :

I've made the current code base GSEAL compatible. The one function unable to be ported is Gtk.Widget's is_toplevel, which gtk+-2.0.vapi still translates into GTK_WIDGET_TOPLEVEL. When we use gtk+-3.0.vapi, that will be fixed. But for the moment, I commented out the additional check (which should be harmless in practice). So we're good for now.

Changed in deja-dup:
assignee: nobody → Michael Terry (mterry)
milestone: none → 15.4
status: Confirmed → Fix Committed
Changed in vala:
status: Confirmed → Fix Released
Michael Terry (mterry) on 2010-07-13
Changed in deja-dup:
milestone: 15.4 → 15.5
Michael Terry (mterry) on 2010-07-13
Changed in deja-dup:
status: Fix Committed → Fix Released
Changed in vala:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.