Deja-dup 34.3 fails to build with vala 0.35.6

[DimStar]

Vala 0.35.x (0.36 to be) fails to translate deja-dup:

[ 9%] Generating ConfigBool.c, ConfigChoice.c, ConfigDelete.c, ConfigEntry.c, ConfigFolder.c, ConfigLabel.c, ConfigLabelBackupDate.c, ConfigLabelDescription.c, ConfigLabelLocation.c, ConfigList.c, ConfigLocation.c, ConfigLocationCustom.c, ConfigLocationDAV.c, ConfigLocationFile.c, ConfigLocationFTP.c, ConfigLocationGCS.c, ConfigLocationGDrive.c, ConfigLocationOpenstack.c, ConfigLocationRackspace.c, ConfigLocationS3.c, ConfigLocationSSH.c, ConfigLocationSMB.c, ConfigLocationTable.c, ConfigLocationU1.c, ConfigLocationVolume.c, ConfigPeriod.c, ConfigRelPath.c, ConfigURLPart.c, ConfigURLPartBool.c, ConfigWidget.c, WidgetUtils.c, widgets.vapi, widgets.h, widgets_internal.h
/home/abuild/rpmbuild/BUILD/deja-dup-34.3/deja-dup/widgets/ConfigList.vala:336.39-336.42: error: Argument 1: Cannot pass value to reference or output parameter
      (model as Gtk.ListStore).remove(iter);
                                      ^^^^
/home/abuild/rpmbuild/BUILD/deja-dup-34.3/deja-dup/widgets/ConfigLocation.vala:400.18-400.21: error: Argument 1: Cannot pass value to reference or output parameter
    store.remove(iter);
                 ^^^^
/home/abuild/rpmbuild/BUILD/deja-dup-34.3/deja-dup/widgets/ConfigLocation.vala:405.22-405.29: error: Argument 1: Cannot pass value to reference or output parameter
        store.remove(sep_iter);
                     ^^^^^^^^

** (valac:12386): CRITICAL **: vala_data_type_get_nullable: assertion 'self != NULL' failed

(valac:12386): GLib-GObject-WARNING **: invalid cast from 'ValaNamespace' to 'ValaTypeSymbol'

(valac:12386): GLib-GObject-WARNING **: invalid cast from 'ValaNamespace' to 'ValaTypeSymbol'

(valac:12386): GLib-GObject-WARNING **: invalid cast from 'ValaNamespace' to 'ValaTypeSymbol'

(valac:12386): GLib-GObject-WARNING **: invalid cast from 'ValaNamespace' to 'ValaTypeSymbol'
Compilation failed: 3 error(s), 0 warning(s)

[Dominique Leuenberger aka DimStar (dimstar)]

The package deja-dup fails to build in openSUSE:Factory. Earlier notifications by email to the bugowner and Maintainer have remained without reaction / fix. If the package is not being fixed within 2 weeks, it will be scheduled for removal from Tumbleweed

https://build.opensuse.org/package/live_build_log/openSUSE:Factory/deja-dup/standard/x86_64

[Zaitor (zaitor)]

For what it's worth, I switch to a git checkout, upstream have ported to meson.

After patching upstreams errors so that it will actually pass "configure" with meson, the build fails in exactly the same way as autotools build.

[Zaitor (zaitor)]

Created attachment 727719
patch needed for meson build

[Michael Terry (mterry)]

Yeah sorry, am in middle of month long trip, will solve this when I get back in July. Thanks for report!

[Jeremy Bícha (jbicha)]

Enjoy the trip!

I'll go ahead and distro-patch this for Ubuntu in the meantime then.

[Jeremy Bícha (jbicha)]

Maybe you should revert your last deja-dup commit so that git master is buildable while you're away.

[Launchpad Janitor (janitor)]

This bug was fixed in the package deja-dup - 34.4-0ubuntu2

---------------
deja-dup (34.4-0ubuntu2) artful; urgency=medium

  * Add patches to fix build with vala 0.36 (LP: #1668915)
    - Don-t-use-static-for-const-declarations.patch
    - Use-ref-keyword-for-iter.patch
  * Bump minimum valac to 0.36, required by this version of the patches
  * debian/control:
    - Drop obsolete XS-Testsuite field

 -- Jeremy Bicha <email address hidden> Fri, 16 Jun 2017 18:34:21 -0400

[Dominique Leuenberger aka DimStar (dimstar)]

Porred the two patches by Jeremy into our package, which now builds fine again with vala 0.36

Submitted to GNOME:Apps (devel prj) from where it will reach Tumbleweed