Skipping track just before the end skips the following track

[Sean Talbot]

I think I've found a bug in how changing track is implemented.

To replicate, select three tracks from your library that have play times of at least 20 - 30 seconds. Put the tracks in the play queue and seek along the first one to around 10s before the end.

Now hit play, and watch the time closely, as you need to press 'Next Track' when there are ~3s left before the track changes manually. Get it right and Decibel skips to the next (i.e. second) track, pauses for half a second, then skips again to the third track.

Can anyone confirm?

[Mark Finger (markfinger)]

From testing, this is caused by the process of buffering the next track 5 secs before the current one ends. Presumably, the buffering process increments the index and when 'next' is performed it moves it one further along the index.

I've attached a patch which sets the buffering to begin .5 secs before the end of the track, rather than 5 secs.

It fixes it for me and does not seem to cause any issues with lag from buffering.

[Anonym25712 (anonym25712)]

The buffering process with Gstreamer is a PITA. This bug happens because when you click next right before the end, the player sees that the next track is the buffered one, and thus let Gstreamer plays it without stopping anything. However, this is fine only when the current track has ended, not when you're trying to skip it.

This should be fixed on the trunk.

[Anonym25712 (anonym25712)]

See v1.08