[Feature Request] Album Art/Cover in Desktop Notification

Bug #418076 reported by Peng Deng
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Decibel Audio Player
Fix Released
Undecided
Anonym25712
Nominated for Trunk by m2xtreme

Bug Description

If the Album Cover and Desk Notification module are both enabled, the notification should use the album cover as icon. If the Album cover is missing or the module is not used, then the notification falls back to use the default decible icon.

Revision history for this message
Ronan Jouchet (ronj) wrote :

That would be a nice addition.
Lots of players do it this way, it is more graphic and "personalizes" each notification

Revision history for this message
m2xtreme (m2xtreme) wrote :

I was thinking the same thing :-) Hope to see it in a future release.

Revision history for this message
Ronan Jouchet (ronj) wrote :

I implemented this, please see the attached patch.
- m2extreme, Peng, could you please test it? Unpack the source tarball from Decibel site, browse inside "decibel-audio-player-1.03", launch "patch < coverDisp.diff" and say you want to patch "src/modules/DesktopNotification.py". Then start Decibel with a "cd src && python decibel-audio-player.py", and you should be good to go. Check the behavior is correct with and without the Covers module.
- François, if you're not OK with the way I do this, please tell me so that I can improve my patch

Details of my job, as presented in the diff:
1. Added MSG_CMD_SET_COVER to the list of events DesktopNotification responds to
2. Added 'cover' to showNotification parameters
3. Made showNotification display the cover when passed a cover as parameter, the decibel icon else
4. All this applies only if the Covers module is started (in this case handleMsg responds to MSG_CMD_SET_COVER), else DesktopNotification goes the old way (responding to MSG_EVT_NEW_TRACK)

Changed in decibel-audio-player:
status: New → In Progress
assignee: nobody → Ronan Jouchet (ronj)
Ronan Jouchet (ronj)
Changed in decibel-audio-player:
assignee: Ronan Jouchet (ronj) → François Ingelrest (athropos)
Revision history for this message
Anonym25712 (anonym25712) wrote :

Fixed on trunk using a different method.

Changed in decibel-audio-player:
status: In Progress → Fix Committed
Revision history for this message
Anonym25712 (anonym25712) wrote :

See v1.04

Changed in decibel-audio-player:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.