Fix gnome failsafe support in lucid (supporting session with arguments

[Didier Roche-Tolomelli]

Binary package hint: xorg

In case of failsafe session, gnome-session is called with -f options.
The bug was in /etc/X11/Xsession.d/20x11-common_process-args where $1 is "gnome-session -f"
This causes some troubles when trying to STARTUP_FULL_PATH=$(/usr/bin/which "$1" || true)
So, we went to else statement, without STARTUP set up

Consequently /etc/X11/Xsession.d/50x11-common_determine-startup set it to /usr/bin/x-session-manager, which is an alternative to gnome-session in lucid.

-----

Also, if seahorse-plugins is installed:
/etc/X11/Xsession.d/60seahorse-plugins will add "gnome-session -f" to $STARTUP (thinking that first bug is fixed).
Unfortunately, STARTUP="$SEAHORSE --execute $STARTUP", --execute doesn't support additional arguments like gnome-session -f. It should be gnome-session -- -f.

This fixes that too.

[Launchpad Janitor (janitor)]

This bug was fixed in the package seahorse-plugins - 2.28.1-0ubuntu5

---------------
seahorse-plugins (2.28.1-0ubuntu5) lucid; urgency=low

  * debian/seahorse-plugins.Xsession: Add support for session command
    containing args (LP: #512235)
 -- Didier Roche <email address hidden> Mon, 25 Jan 2010 10:30:43 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg - 1:7.5+1ubuntu2

---------------
xorg (1:7.5+1ubuntu2) lucid; urgency=low

  [ David Planella ]
  * Completed internationalisation support for failsafeXinit (LP: #335678)

  [ Didier Roche ]
  * debian/local/Xsession.d/20x11-common_process-args: Add support for
    session command containing args (LP: #512235)

  [ Bryce Harrington ]
  * debian/local/Failsafe/failsafeXinit: Remove all use of dexconf, as it
    no longer does anything interesting. Instead, to restore a system to
    default configuration, just remove the xorg.conf after backing it up.
  * debian/local/Failsafe/failsafeDexconf: Drop script since it is no
    longer needed by failsafe.
  * debian/apport/source_xorg.py: Update info apport collects on X issues
    - Include make.log and dkms status info for proprietary drivers
    - Collect -nouveau version
    - Don't expect xorg.conf or Xorg.0.log.old to always be present
    - Don't run commands that need X if X is not available (LP: #368282)

  [ Timo Aaltonen ]
  * Add wacom back to -input-all.
 -- Bryce Harrington <email address hidden> Mon, 25 Jan 2010 15:33:13 -0800

[Doug Whitfield (douglasawh)]

Can someone explain to me what this means on the user end? I'm wondering if I need to file another bug. I'm assuming so, since this one appears to be fixed.

I've reproduced GNOME locking up on three different machines all of the same model, both 32-bit and x64 versions, both failsafe and not failsafe. I'm guessing mine is ATI related since the model I am testing on has an ATI card.

[Didier Roche-Tolomelli (didrocks)]

that just means that failsafe session which was working on karmic and not in lucid. I fixed the way it was working previously.
If in your failsafe lucid session, you have : env | grep -i session contained in one line something like gnome-session -f, you should just open another bug.