ultrastar-ng.desktop points to an inexisting .xpm file

[rettichschnidi]

Binary package hint: ultrastar-ng

first:

$ dpkg-query -L ultrastar-ng-gstreamer|egrep 'desktop|xpm'
/usr/share/games/applications/ultrastar-ng.desktop
/usr/share/games/pixmaps/ultrastar-ng.xpm
/usr/share/pixmaps/ultrastar-ng.xpm
/usr/share/applications/ultrastar-ng.desktop

Why are there .desktop and .xpm files under /user/share/games/ ? Never seen before.

second:

$ cat /usr/share/games/applications/ultrastar-ng.desktop|grep Icon
Icon=ultrastar-ng.xpm

seems to be OK, but:

cat /usr/share/applications/ultrastar-ng.desktop|grep Icon
Icon=ultrastar-ng64bis.xpm

The Icon name is wrong in the file /usr/share/applications/ultrastar-ng.desktop
Since my gnome menu displays this (and only this, doesn't display the one under games) .desktop-file, there is no nice Icon.

[Basilio Kublik (sourcercito)]

confirmed in gutsy

ultrastar-ng 0.1.4-2

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Confirmed on Hardy, I'm working on this.

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

I've forwarded this to Debian

[Cesare Tirabassi (norsetto)]

Thanks Mario.
The package seems indeed quite messy on this, I see 3 icons in debian + another in the source, 1 desktop file in debian and another in the source and 1 menu. The only icon which is installed is neither used by the .desktop nor by the menu (because the name in the menu is wrong).
I would:

- correct the icon name in the menu
- install the additional icon for the desktop
- correct the installation of icon and desktop in /usr/share/games

Note that rules defines --datadir=\$${prefix}/share/games and that the Makefile.am in the data dir of the source is using it for the upstream icon and desktop installation.

Can you do that?

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Thank you for your comment Cesare, I hope that this debdiff covers your suggestion.

[Cesare Tirabassi (norsetto)]

This only fix the desktop and icon for ultrastar-ng-streamer but also installs the game data in /usr/share/ultrastar-ng/ instead of /usr/share/games/ultrastar-ng/ which was chosen by Debian.
The package ultrasta-ng-xine is not affected (its another rules target).
Also, if they are not used anymore, it makes sense to remove whatever .desktop and icons are in debian/.
In my opinion the best is to try to coordinate this with Debian, they may have other ideas as well (for instance patching Makefile.in or using some other icon than the one from upstream).

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Honestly, I haven't understood very well what to do.

[Cesare Tirabassi (norsetto)]

1) There are two binary packages, you corrected one (ultrastar-ng-streamer) but forgot about the other (ultrasta-ng-xine).
2) For the package that you corrected, your correction solves the installation of the icon, but, as a side effects, installs all the game data in /usr/share/ultrastar-ng/ instead of /usr/share/games/ultrastar-ng/, which was the location chosen by Debian.
3) Your solution uses the icon and .desktop files from upstream, therefore, why do we keep the other icons and .desktop file from Debian in debian/ ?

Finally, and more importantly, I'm asking you to coordinate the resolution with Debian; they may want to use one of the icons in debian/ instead of the one from upstream and they may want to solve the problem differently. Since we want to minimise our delta we should try to have a common solution.

Is that clearer?

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

I hope that Debian will reply soon; in the meantime, what about this ?

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Sorry, I forgot to update debian/changelog.

[Miriam Ruiz (miry)]

Thanks for the report about the icon, Mario. I'm seeing how to fix it in the newer release.

I'll keep the game data in /usr/share/games/ though. I don't know in Ubuntu, but it's where data for games belong according to FHS ( http://www.thedumbterminal.co.uk/information/fhs.shtml )

[Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Thank you Miriam. :)