Comment 15 for bug 1666570

I've reviewed and uploaded Josh's MPs for tomcat8. Since there are three and some review comments are shared, I'm writing them up here to avoid confusion between the multiple MPs.

For all three, I had to s/tomcat7/tomcat8/ in the conffile pathname, as this has switched in tomcat8.

For Zesty, I changed the version from 8.0.38-2ubuntu1.1 to 8.0.38-2ubuntu2. 1.1 would work, but convention for the development release is that we would use ubuntu2. Exceptionally we are in final freeze so it may become an SRU anyway.

I missed that tomcat8 Zesty wasn't fixed before. I would have required this before uploading tomcat7 too had I noticed, because really the SRU rule of "fix development first" should apply in spirit between tomcat7 and tomcat8 because it is only a technicality that they have different source package names in this case. But as we're including Zesty in this upload, we're fixing that up anyway, and the tomcat7 fixes haven't hit the release pocket yet so users of not -proposed won't see a regression.

There was a bug in the "usd import" tool that caused Josh's Yakkety fixes to be based on 8.0.37-1 instead of 8.0.37-1ubuntu0.1 that is in yakkety-security currently. So the upload got rejected, I noticed, and rebased Josh's changes on top of the yakkety-security tree for now. The yakkety-devel branch pointer in the git imported tomcat8 repository is still wrong, but I think it may fix itself when it imports this upload. The commit hash will still be "wrong", but will be fixed when we re-import.

Release and SRU teams: as the SRU for tomcat7 is already in progress (due to my previous review omission), I figured that having this in the Zesty unapproved queue would be the best thing to do for now. It's a minor fix so we can skip it for Zesty release if you like, but we should process it as post-release SRU in Zesty as Josh is SRUing all the other releases anyway and Zesty would be left out otherwise.