Debian GNU/Linux

tomcat6-instance-create should allow -c -1

Reported by Michael Schnupp on 2011-01-25
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tomcat6 (Debian)
Fix Released
Unknown
tomcat6 (Ubuntu)
Low
Abhinav Upadhyay

Bug Description

Binary package hint: tomcat6

According to http://tomcat.apache.org/tomcat-6.0-doc/config/server.html
the port attribute of the server can be set to -1 to disable the "control port".
tomcat6-instance-create accepts the -c option to specify exactly that port, but complains about -1 not being a valid TCP port number.

Allowing disabling that port in tomcat6-instance-create would be nice.

Related branches

lp:~er-abhinav-upadhyay/ubuntu/natty/tomcat6/bug707405
Merged into lp:ubuntu/natty/tomcat6 at revision 33
Dave Walker: Approve on 2011-03-09
Barry Warsaw: Needs Fixing on 2011-03-07
Clint Byrum: Pending requested 2011-03-08
Ubuntu branches: Pending requested 2011-03-07
Thierry Carrez (ttx) on 2011-01-26
Changed in tomcat6 (Ubuntu):
importance: Undecided → Low
status: New → Triaged
tags: added: bitesize

I have modified the tomcat6-instance-create to accept -1 as a value of the -c option.

Now, if a user specifies -1 as a value for the -c option, the server will get configured and instantiated properly, but the user will be given a warning that he will have to kill the server manually.

I have attached the patch.

Changed in tomcat6 (Ubuntu):
status: Triaged → In Progress
tags: added: patch
Changed in tomcat6 (Ubuntu):
assignee: nobody → Abhinav Upadhyay (er-abhinav-upadhyay)

Using a regex test to verify the port numbers as suggest by Clint Byrum and Barry during their review of the previous patch.

Thierry Carrez (ttx) wrote :

I'll push this to debian SVN once it's in Ubuntu, so that we can sync again when oneiric opens.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tomcat6 - 6.0.28-10ubuntu1

---------------
tomcat6 (6.0.28-10ubuntu1) natty; urgency=low

  [ Abhinav Upadhyay ]
  * tomcat6-instance-create should accept -1 as the value of -c option
    as per http://tomcat.apache.org/tomcat-6.0-doc/config/server.html
    (LP: #707405)

  [ Dave Walker (Daviey) ]
  * debian/control: Updated Maintainer as per policy.
 -- Abhinav Upadhyay <email address hidden> Mon, 07 Mar 2011 13:38:05 +0530

Changed in tomcat6 (Ubuntu):
status: In Progress → Fix Released
Changed in tomcat6 (Debian):
status: Unknown → New
Changed in tomcat6 (Debian):
status: New → Fix Committed
Thierry Carrez (ttx) wrote :

I was beaten to it by Tony Mancill :)

Changed in tomcat6 (Debian):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.