diffusion.querycommits deprecated in favor of diffusion.commit.search which support hasn't been merged for yet
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-phabricator (Debian) |
Fix Released
|
Unknown
|
|||
python-phabricator (Ubuntu) |
Fix Released
|
High
|
Simon Quigley | ||
Bionic |
Fix Released
|
High
|
Simon Quigley | ||
Cosmic |
Fix Released
|
High
|
Simon Quigley |
Bug Description
[Impact]
Without this, users of the API will eventually be unable to search commits in Phabricator, something that is essential to some programs.
[Test Case]
In the Python interactive console, first import the library:
phab = Phabricator(host="https:/
(for example)
Then, with an example commit hash, run this:
phab.diffusion.
It should correctly return a result, rather than erroring out as shown below.
[Regression Potential]
Very unlikely. If the interpretation of the JSON file somehow changes in the underlying Python code, it could regress, but the more likely scenario is that the API changes again in upstream Phabricator, which will need another SRU to adjust.
[Original Description]
I'm looking to improve some Phabricator code for Lugito (Lubuntu's Python script which acts as a hook for commits such as IRC notifications), and I can't use diffusion.
>>> phab.diffusion.
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/
return self._request(
File "/usr/lib/
data = self._parse_
File "/usr/lib/
raise APIError(
phabricator.
However, my Phabricator instance (last updated about a week ago) says this under diffusions.
Frozen Method: This method is frozen and will eventually be deprecated. New code should use "diffusion.
A patch adding support for this is available upstream: https:/
This needs to be backported, or functionality will be lost.
Changed in python-phabricator (Ubuntu Bionic): | |
status: | New → Confirmed |
Changed in python-phabricator (Ubuntu Cosmic): | |
status: | New → Confirmed |
Changed in python-phabricator (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in python-phabricator (Ubuntu Cosmic): | |
importance: | Undecided → High |
Changed in python-phabricator (Ubuntu Bionic): | |
assignee: | nobody → Simon Quigley (tsimonq2) |
Changed in python-phabricator (Ubuntu Cosmic): | |
assignee: | nobody → Simon Quigley (tsimonq2) |
description: | updated |
Changed in python-phabricator (Debian): | |
status: | Unknown → New |
tags: |
added: verification-done verification-done-bionic removed: verification-needed verification-needed-bionic |
Changed in python-phabricator (Debian): | |
status: | New → Fix Released |
https:/ /launchpad. net/ubuntu/ +source/ python- phabricator/ 0.7.0-1ubuntu1