OpenRPG current version is out of date.

[basotl]

Binary package hint: openrpg

Current OpenRPG client available in the Ubuntu Gutsy and Hardy repositories is out of date.

The current version in the repositories is 1.6.3-1ubuntu1
The version currently available from SourceForge.net 1.7.1.
http://sourceforge.net/projects/openrpg/

[Roberto D'Auria (everlastingfire)]

I've updated this from upstream (http://sourceforge.net/projects/openrpg/files/), please review.

[Roberto D'Auria (everlastingfire)]

debdiff between openrpg_1.6.3-1.1ubuntu1.dsc and openrpg_1.7.1-0ubuntu1.dsc

[Roberto D'Auria (everlastingfire)]

fixed diff.gz

[Fabrice Coutadeur (fabricesp)]

Hi,

Why do you think that both existing patches are not required anymore? A quick look at the source does not make it clear to me, especially with python_interpreter_path. About fix_work_directory, it seems fixed upastream, but could you please make a test?

Thanks,

Fabrice

[Roberto D'Auria (everlastingfire)]

I can't work on this for a little cause I'm on holidays, next week I'll test it more carefully.

[Roberto D'Auria (everlastingfire)]

I removed the patches already applied upstream. This is the new diff.

[Roberto D'Auria (everlastingfire)]

Fixed python_intepreter_path.

[Fabrice Coutadeur (fabricesp)]

Taking for sponsorship

[Fabrice Coutadeur (fabricesp)]

Sorry, but it seems that the patches in your debdiff are not right:
- I don't see meta_server_lib.py in python_interpreter_path patch
- Also there is a new change in start.py, not related to interpreter
- fix_work_directory ahs a change in interpreter in start.py that should go into the other patch
- there are a lot of 'non-sense' lines, with apparently no changes.

Can you check and fix the patches, please?

Thanks,
Fabrice

[Roberto D'Auria (everlastingfire)]

Sorry, it's my first package update. I did it another time, following your hints. These are the steps I've done:
- download the new source, extracted and renamed the archive to openrpg_1.7.1.orig.tar.gz
- apt-get source openrpg, for the old source + diff.gz
- copied the old debian/ dir
- dch -i and edited the changelog
So, I removed old patches and re-created them with quilt inserting only required changes.
Then, `quilt pop -a` and `debuild -S -sa`. The generated diff.gz is attached to this comment.

Am I doing something wrong? What the 'non-sense' lines are?

I hope this is right.

[Roberto D'Auria (everlastingfire)]

There's a problem: the source code is all encoded in MS-DOS mode (CR LF instead of LF), and without switching to UNIX mode exec or the bash itself don't recognize the interpreter. The old (1.6.3) source code was encoded in UNIX mode.

bash: ./start.py: /usr/bin/python^M: bad interpreter: No such file or directory

How should I act on this? re-encode the original source code file-by-file?

[Fabrice Coutadeur (fabricesp)]

Hi,

From what I've seen, this is the patch that adds this ^M characters, so if you fix/update the patch, it should be ok.

The 'non-sens' lines in the patch are this kind of lines:
+- app.MainLoop()
+\ No newline at end of file
++ app.MainLoop()

or

+- mapFile = mapElement.getAttribute( 'file' )
++ mapFile = mapElement.getAttribute( 'file' )

The patch should only contains real changes, and not 'fake' ones...

Thanks,
Fabrice

[Roberto D'Auria (everlastingfire)]

It isn't the patch. Download the upstream source code and open a file (I just tried "start.py") with an editor like "vi" or "geany", with end-lines visualization active. You'll see it shows a ^M after every line, and is this causing bash to fail on "#!/usr/bin/python^M". It's an uptream issue, they're using MS-DOS mode and it can't work on Ubuntu without a fix.

Please, let me know how to proceed. For the other issue ('fake' patches), I already resolved.

[Roberto D'Auria (everlastingfire)]

I fixed it adding a script for converting .py files to UNIX mode in rules.
All the patches are fixed, too.

[Roberto D'Auria (everlastingfire)]

I fixed many lintian info and warnings, too.

[Launchpad Janitor (janitor)]

This bug was fixed in the package openrpg - 1.7.1-0ubuntu1

---------------
openrpg (1.7.1-0ubuntu1) lucid; urgency=low

  * New upstream release (LP: #177560)
  * Add conversion from MS-DOS endlines to UNIX ones.
  * Fix "debian-watch-file-is-missing" lintian info
  * Fix "debian-rules-sets-DH_COMPAT" lintian warning
  * Fix "binary-arch-rules-but-pkg-is-arch-indep" lintian warning
  * Fix "build-depends-without-arch-dep" lintian info
  * Fix "ancient-standards-version" lintian warning
  * Fix "quilt-patch-missing-description" lintian info
  * Change debhelper in build-depends to >= 5
 -- Roberto D'Auria <email address hidden> Sat, 09 Jan 2010 20:18:12 +0100