FTBFS: open-iscsi build from source fails with undefined reference to `minor'

[Scott Moser]

Current build of open-iscsi (2.0.874-5ubuntu7) will fail to build from source.

Seems to be related to the issue listed here:
 https://github.com/hishamhm/htop/issues/663
and fix
 https://github.com/hishamhm/htop/commit/c01f40eb3e599f55d408448228d95ecee4b2031f

It ends in:
mv -f .deps/iscsiuio-ping.Tpo .deps/iscsiuio-ping.Po
gcc -DHAVE_CONFIG_H -I. -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../../src/uip -I../../src/apps/brcm-iscsi -I../../src/apps/dhcpc -I../../src/unix/libs -I../../../include -I../../../usr -DBYTE_ORDER=LITTLE -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -DOFFLOAD_BOOT_SUPPORTED -Wall -MT iscsiuio-sysdeps.o -MD -MP -MF .deps/iscsiuio-sysdeps.Tpo -c -o iscsiuio-sysdeps.o `test -f '../../../utils/sysdeps/sysdeps.c' || echo './'`../../../utils/sysdeps/sysdeps.c
mv -f .deps/iscsiuio-sysdeps.Tpo .deps/iscsiuio-sysdeps.Po
/bin/bash ../../libtool --tag=CC --mode=link gcc -I../../src/uip -I../../src/apps/brcm-iscsi -I../../src/apps/dhcpc -I../../src/unix/libs -I../../../include -I../../../usr -DBYTE_ORDER=LITTLE -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -DOFFLOAD_BOOT_SUPPORTED -Wall -ldl -rdynamic -lpthread -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -o iscsiuio iscsiuio-build_date.o iscsiuio-main.o iscsiuio-clock-arch.o iscsiuio-logger.o iscsiuio-nic.o iscsiuio-nic_id.o iscsiuio-nic_vlan.o iscsiuio-nic_nl.o iscsiuio-nic_utils.o iscsiuio-packet.o iscsiuio-iscsid_ipc.o iscsiuio-ping.o iscsiuio-sysdeps.o ../../src/uip/lib_iscsi_uip.a ../../src/apps/dhcpc/lib_apps_dhcpc.a ../../src/apps/brcm-iscsi/lib_apps_brcm_iscsi.a ../../src/unix/libs/lib_iscsiuio_hw_cnic.a
libtool: link: gcc -I../../src/uip -I../../src/apps/brcm-iscsi -I../../src/apps/dhcpc -I../../src/unix/libs -I../../../include -I../../../usr -DBYTE_ORDER=LITTLE -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -DOFFLOAD_BOOT_SUPPORTED -Wall -rdynamic -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-z -Wl,now -o iscsiuio iscsiuio-build_date.o iscsiuio-main.o iscsiuio-clock-arch.o iscsiuio-logger.o iscsiuio-nic.o iscsiuio-nic_id.o iscsiuio-nic_vlan.o iscsiuio-nic_nl.o iscsiuio-nic_utils.o iscsiuio-packet.o iscsiuio-iscsid_ipc.o iscsiuio-ping.o iscsiuio-sysdeps.o -ldl -lpthread ../../src/uip/lib_iscsi_uip.a ../../src/apps/dhcpc/lib_apps_dhcpc.a ../../src/apps/brcm-iscsi/lib_apps_brcm_iscsi.a ../../src/unix/libs/lib_iscsiuio_hw_cnic.a
/usr/bin/ld: ../../src/unix/libs/lib_iscsiuio_hw_cnic.a(bnx2.o): in function `bnx2_open':
./iscsiuio/src/unix/libs/bnx2.c:483: undefined reference to `minor'
/usr/bin/ld: ../../src/unix/libs/lib_iscsiuio_hw_cnic.a(bnx2x.o): in function `bnx2x_open':
./iscsiuio/src/unix/libs/bnx2x.c:754: undefined reference to `minor'
collect2: error: ld returned 1 exit status

[Scott Moser (smoser)]

After some code motion the this was fixed upstream at
 https://github.com/open-iscsi/open-iscsi/commit/6d68ef5871c94c6ebbbe6e6b1fe0bc2dce711052

[Launchpad Janitor (janitor)]

This bug was fixed in the package open-iscsi - 2.0.874-5ubuntu8

---------------
open-iscsi (2.0.874-5ubuntu8) cosmic; urgency=medium

  * d/tests: insert some debug units in an attempt to diagnose any
    occurences of bug 1788188.
  * Fix fail to build from source due to undefined reference to
    minor (LP: #1791154)

 -- Scott Moser <email address hidden> Tue, 21 Aug 2018 13:33:06 -0400