Illegal modification of LM-SENSORS MIB

[Debian Bug Importer]

Automatically imported from Debian bug report #249904 http://bugs.debian.org/249904

[Jochen Friedrich (jochen)]

tag 249839 +experimental
tag 249904 +experimental
thanks

[Jochen Friedrich (jochen)]

tag 249904 +patch
thanks

[Jochen Friedrich (jochen)]

tag 249839 +upstream
tag 249904 +upstream
forwarded 249839 http://sourceforge.net/projects/net-snmp/
forwarded 249904 http://sourceforge.net/projects/net-snmp/
thanks

[Jochen Friedrich (jochen)]

Source: net-snmp
Source-Version: 5.1.2-5

We believe that the bug you reported is fixed in the latest version of
net-snmp, which is due to be installed in the Debian FTP archive:

libsnmp-base_5.1.2-5_all.deb
  to pool/main/n/net-snmp/libsnmp-base_5.1.2-5_all.deb
libsnmp-perl_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp-perl_5.1.2-5_alpha.deb
libsnmp5-dev_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp5-dev_5.1.2-5_alpha.deb
libsnmp5_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp5_5.1.2-5_alpha.deb
net-snmp_5.1.2-5.diff.gz
  to pool/main/n/net-snmp/net-snmp_5.1.2-5.diff.gz
net-snmp_5.1.2-5.dsc
  to pool/main/n/net-snmp/net-snmp_5.1.2-5.dsc
snmp_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/snmp_5.1.2-5_alpha.deb
snmpd_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/snmpd_5.1.2-5_alpha.deb
tkmib_5.1.2-5_all.deb
  to pool/main/n/net-snmp/tkmib_5.1.2-5_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Friedrich <email address hidden> (supplier of updated net-snmp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 23 Sep 2004 18:45:41 +0200
Source: net-snmp
Binary: libsnmp5 tkmib libsnmp5-dev snmp libsnmp-perl libsnmp-base snmpd
Architecture: source all alpha
Version: 5.1.2-5
Distribution: unstable
Urgency: medium
Maintainer: Jochen Friedrich <email address hidden>
Changed-By: Jochen Friedrich <email address hidden>
Description:
 libsnmp-base - NET SNMP (Simple Network Management Protocol) MIBs and Docs
 libsnmp-perl - NET SNMP (Simple Network Management Protocol) Perl5 Support
 libsnmp5 - NET SNMP (Simple Network Management Protocol) Library
 libsnmp5-dev - NET SNMP (Simple Network Management Protocol) Development Files
 snmp - NET SNMP (Simple Network Management Protocol) Apps
 snmpd - NET SNMP (Simple Network Management Protocol) Agents
 tkmib - NET SNMP (Simple Network Management Protocol) MIB Browser
Closes: 244721 249839 249904 264442 266270 267691
Changes:
 net-snmp (5.1.2-5) unstable; urgency=medium
 .
   * Commented out remaining MemShared message
     Thanks to Johan Thelmén (Really closes: #244721)
   * New version of lm-sensors from upstream (Thanks to Mike Slifcak).
     lm-sensors is now enabled again on i386.
     Closes: #264442, #267691, #249839, #249904, 266270
Files:
 2e9818e5afd366a0ac9f70878ebedd38 790 net optional net-snmp_5.1.2-5.dsc
 a446be233c323842927985d4dfa8d6c6 66184 net optional net-snmp_5.1.2-5.diff.gz
 db65a1da46c4e148c0cb632b64b7c1d4 1004850 libs optional libsnmp-base_5.1.2-5_all.deb
 73ba32225637509ba920ffdfd60f8a62 754204 net optional tkmib_5.1.2-5_all.deb
 11d0bc8ab03f823c484cb1b14b08ebaa 732864 net optional snmpd_5.1.2-5_alpha.deb
 8b197c127b12bda3a41f6a2fb3b46c4f 820418 net optional snmp_5.1.2-5_...

[Jochen Friedrich (jochen)]

reopen 249904
severity 249904 serious
thanks

Hi Peter,

unfortunately, upstream has reverted this patch. The reason is that once
a MIB is published, it can only be extended, but no objects can be
altered anymore.
It was suggested to assign new columns in the table for the negative
values. Until this is fixed, i'm setting the severity to serious to
avoid this altered MIB
entering sarge.

See:
http://sourceforge.net/tracker/index.php?func=detail&aid=1027522&group_id=12694&atid=312694

Thanks,
Jochen

[Jochen Friedrich (jochen)]

tags 249904 -experimental
retitle 249904 Illegal modification of LM-SENSORS MIB
thanks

[Debian Bug Importer (debzilla)]

Automatically imported from Debian bug report #249904 http://bugs.debian.org/249904

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Wed, 19 May 2004 21:20:15 +0200
From: Peter Hirdina <email address hidden>
To: <email address hidden>
Subject: snmpd reports no negative values for sensors handled by lm_sensors

--------_40ABB165F48B025B2D98_MULTIPART_MIXED_
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

Package: snmpd
Version: 5.1.1-2

I noticed that I can't get negative values from my sensors. As soon as I
noticed that they are all defined as unsigned ints, it became quiet clear
to me. I redefined them where appropriate (see attached patch). Every
sensor type except fan speed sensors should be able to hold a negativ
value. That includes temp, voltage and misc sensors. Ok, for temp sensors
a negative value is really unlikely, but more likely than such a high
readout that we need a full 2^32 bit value. I guess in such a case there
isn't much left to monitor anyway ;). And for the others I think it's
quite clear that they could hold negative values.

I modified the code and the MIB file (hope that we're all places).

cheers,
    Peter

---------------------------------------------------------------------
  Peter Hirdina Frauenstrasse 128
  <email address hidden> 89073 Ulm / Germany
---------------------------------------------------------------------
    PGP Key available, send request to <email address hidden>
---------------------------------------------------------------------

--------_40ABB165F48B025B2D98_MULTIPART_MIXED_
Content-Type: application/octet-stream; name="net-snmp-5.1.1-2.lm_sensors.negative-values.patch"
Content-Disposition: attachment;
 filename="net-snmp-5.1.1-2.lm_sensors.negative-values.patch"
Content-Transfer-Encoding: base64

LS0tIG5ldC1zbm1wLTUuMS4xLm9yaWcvYWdlbnQvbWliZ3JvdXAvdWNkLXNubXAvbG1TZW5zb3Jz
LmMKKysrIG5ldC1zbm1wLTUuMS4xL2FnZW50L21pYmdyb3VwL3VjZC1zbm1wL2xtU2Vuc29ycy5j
CkBAIC01NSw3ICs1NSw3IEBACiAgICAge0xNVEVNUFNFTlNPUlNERVZJQ0UsIEFTTl9PQ1RFVF9T
VFIsIFJPTkxZLCB2YXJfbG1TZW5zb3JzVGFibGUsIDMsCiAgICAgIHsyLCAxLCAyfX0sCiAjZGVm
aW5lICAgTE1URU1QU0VOU09SU1ZBTFVFICAgIDUKLSAgICB7TE1URU1QU0VOU09SU1ZBTFVFLCBB
U05fR0FVR0UsIFJPTkxZLCB2YXJfbG1TZW5zb3JzVGFibGUsIDMsCisgICAge0xNVEVNUFNFTlNP
UlNWQUxVRSwgQVNOX0lOVEVHRVIsIFJPTkxZLCB2YXJfbG1TZW5zb3JzVGFibGUsIDMsCiAgICAg
IHsyLCAxLCAzfX0sCiAjZGVmaW5lICAgTE1GQU5TRU5TT1JTSU5ERVggICAgIDgKICAgICB7TE1G
QU5TRU5TT1JTSU5ERVgsIEFTTl9JTlRFR0VSLCBST05MWSwgdmFyX2xtU2Vuc29yc1RhYmxlLCAz
LApAQCAtNzMsNyArNzMsNyBAQAogICAgIHtMTVZPTFRTRU5TT1JTREVWSUNFLCBBU05fT0NURVRf
U1RSLCBST05MWSwgdmFyX2xtU2Vuc29yc1RhYmxlLCAzLAogICAgICB7NCwgMSwgMn19LAogI2Rl
ZmluZSAgIExNVk9MVFNFTlNPUlNWQUxVRSAgICAxNQotICAgIHtMTVZPTFRTRU5TT1JTVkFMVUUs
IEFTTl9HQVVHRSwgUk9OTFksIHZhcl9sbVNlbnNvcnNUYWJsZSwgMywKKyAgICB7TE1WT0xUU0VO
U09SU1ZBTFVFLCBBU05fSU5URUdFUiwgUk9OTFksIHZhcl9sbVNlbnNvcnNUYWJsZSwgMywKICAg
ICAgezQsIDEsIDN9fSwKICNkZWZpbmUgICBMTU1JU0NTRU5TT1JTSU5ERVggICAgMTgKICAgICB7
TE1NSVNDU0VOU09SU0lOREVYLCBBU05fSU5URUdFUiwgUk9OTFksIHZhcl9sbVNlbnNvcnNUYWJs
ZSwgMywKQEAgLTgyLDcgKzgyLDcgQEAKICAgICB7TE1NSVNDU0VOU09SU0RFVklDRSwgQVNOX09D
VEVUX1NUUiwgUk9OTFksIHZhcl9sbVNlbnNvcnNUYWJsZSwgMywKICAgICAgezUsIDEsIDJ9fSwK
ICNkZWZ...

[Debian Bug Importer (debzilla)]

Message-ID: <Pine.LNX.4.58.0408171139430.3075@localhost>
Date: Tue, 17 Aug 2004 11:40:29 +0200 (CEST)
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Subject: tag

tag 249839 +experimental
tag 249904 +experimental
thanks

[Debian Bug Importer (debzilla)]

Message-ID: <Pine.LNX.4.58.0408262120160.1607@localhost>
Date: Thu, 26 Aug 2004 21:20:35 +0200 (CEST)
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Subject: tag

tag 249904 +patch
thanks

[Debian Bug Importer (debzilla)]

Message-ID: <Pine.LNX.4.58.0409132319520.8232@localhost>
Date: Mon, 13 Sep 2004 23:21:20 +0200 (CEST)
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Subject: tagit

tag 249839 +upstream
tag 249904 +upstream
forwarded 249839 http://sourceforge.net/projects/net-snmp/
forwarded 249904 http://sourceforge.net/projects/net-snmp/
thanks

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Thu, 23 Sep 2004 16:17:09 -0400
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Subject: Bug#249904: fixed in net-snmp 5.1.2-5

Source: net-snmp
Source-Version: 5.1.2-5

We believe that the bug you reported is fixed in the latest version of
net-snmp, which is due to be installed in the Debian FTP archive:

libsnmp-base_5.1.2-5_all.deb
  to pool/main/n/net-snmp/libsnmp-base_5.1.2-5_all.deb
libsnmp-perl_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp-perl_5.1.2-5_alpha.deb
libsnmp5-dev_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp5-dev_5.1.2-5_alpha.deb
libsnmp5_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/libsnmp5_5.1.2-5_alpha.deb
net-snmp_5.1.2-5.diff.gz
  to pool/main/n/net-snmp/net-snmp_5.1.2-5.diff.gz
net-snmp_5.1.2-5.dsc
  to pool/main/n/net-snmp/net-snmp_5.1.2-5.dsc
snmp_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/snmp_5.1.2-5_alpha.deb
snmpd_5.1.2-5_alpha.deb
  to pool/main/n/net-snmp/snmpd_5.1.2-5_alpha.deb
tkmib_5.1.2-5_all.deb
  to pool/main/n/net-snmp/tkmib_5.1.2-5_all.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jochen Friedrich <email address hidden> (supplier of updated net-snmp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 23 Sep 2004 18:45:41 +0200
Source: net-snmp
Binary: libsnmp5 tkmib libsnmp5-dev snmp libsnmp-perl libsnmp-base snmpd
Architecture: source all alpha
Version: 5.1.2-5
Distribution: unstable
Urgency: medium
Maintainer: Jochen Friedrich <email address hidden>
Changed-By: Jochen Friedrich <email address hidden>
Description:
 libsnmp-base - NET SNMP (Simple Network Management Protocol) MIBs and Docs
 libsnmp-perl - NET SNMP (Simple Network Management Protocol) Perl5 Support
 libsnmp5 - NET SNMP (Simple Network Management Protocol) Library
 libsnmp5-dev - NET SNMP (Simple Network Management Protocol) Development Files
 snmp - NET SNMP (Simple Network Management Protocol) Apps
 snmpd - NET SNMP (Simple Network Management Protocol) Agents
 tkmib - NET SNMP (Simple Network Management Protocol) MIB Browser
Closes: 244721 249839 249904 264442 266270 267691
Changes:
 net-snmp (5.1.2-5) unstable; urgency=medium
 .
   * Commented out remaining MemShared message
     Thanks to Johan Thelmén (Really closes: #244721)
   * New version of lm-sensors from upstream (Thanks to Mike Slifcak).
     lm-sensors is now enabled again on i386.
     Closes: #264442, #267691, #249839, #249904, 266270
Files:
 2e9818e5afd366a0ac9f70878ebedd38 790 net optional net-snmp_5.1.2-5.dsc
 a446be233c323842927985d4dfa8d6c6 66184 net optional net-snmp_5.1.2-5.diff.gz
 db65a1da46c4e148c0cb632b64b7c1d4 1004850 libs optional libsnmp-base_5.1.2-5_all.deb
 73ba322256...

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Thu, 30 Sep 2004 18:46:43 +0200
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Cc: <email address hidden>
Subject: Patch reverted upstream

reopen 249904
severity 249904 serious
thanks

Hi Peter,

unfortunately, upstream has reverted this patch. The reason is that once
a MIB is published, it can only be extended, but no objects can be
altered anymore.
It was suggested to assign new columns in the table for the negative
values. Until this is fixed, i'm setting the severity to serious to
avoid this altered MIB
entering sarge.

See:
http://sourceforge.net/tracker/index.php?func=detail&aid=1027522&group_id=12694&atid=312694

Thanks,
Jochen

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Thu, 30 Sep 2004 18:48:52 +0200
From: Jochen Friedrich <email address hidden>
To: <email address hidden>
Subject: Retitle

tags 249904 -experimental
retitle 249904 Illegal modification of LM-SENSORS MIB
thanks

[Matt Zimmerman (mdz)]

Warty didn't inherit the MIB change

[Steve Langasek (vorlon)]

Jochen,

The version of snmpd containing this buggy MIB already reached testing
before you reopened the bug report at 'serious', so this needs to be
resolved before the sarge release. Assuming that updating the MIB with
new objects will take a while, I think we probably need a new upload
that reverts this MIB change?

Thanks,
--
Steve Langasek
postmodern programmer

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Sat, 2 Oct 2004 03:02:10 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: Re: Illegal modification of LM-SENSORS MIB

--P+33d92oIH25kiaB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Jochen,

The version of snmpd containing this buggy MIB already reached testing
before you reopened the bug report at 'serious', so this needs to be
resolved before the sarge release. Assuming that updating the MIB with
new objects will take a while, I think we probably need a new upload
that reverts this MIB change?

Thanks,
--=20
Steve Langasek
postmodern programmer

--P+33d92oIH25kiaB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBXnyhKN6ufymYLloRAuz7AJ0WF+XOPKoazkPhRziEJmWw6xX+MACbBFmH
gOKqUHQgRdAyOdEKfV4ANYc=
=XyQf
-----END PGP SIGNATURE-----

--P+33d92oIH25kiaB--

[Jochen Friedrich (jochen)]

Hi Steve,

> The version of snmpd containing this buggy MIB already reached testing
> before you reopened the bug report at 'serious', so this needs to be
> resolved before the sarge release. Assuming that updating the MIB with
> new objects will take a while, I think we probably need a new upload
> that reverts this MIB change?

I hope updating the MIB can be done pretty quick. Upstream got the
authorisation from the original MIB author to assign the ownership to the
net-snmp project. However, yet another bug (#274624) was opened and needs
to be addressed for sarge. I plan to make an high priority upload as soon
as the MIB issue is resolved or end of this week (whatever happens
earlier) to close this bug.

Thanks,
Jochen

[Debian Bug Importer (debzilla)]

Message-ID: <Pine.LNX.4.58.0410031852500.1816@localhost>
Date: Sun, 3 Oct 2004 18:57:08 +0200 (CEST)
From: Jochen Friedrich <email address hidden>
To: Steve Langasek <email address hidden>, <email address hidden>
Subject: Re: Bug#249904: Illegal modification of LM-SENSORS MIB

Hi Steve,

> The version of snmpd containing this buggy MIB already reached testing
> before you reopened the bug report at 'serious', so this needs to be
> resolved before the sarge release. Assuming that updating the MIB with
> new objects will take a while, I think we probably need a new upload
> that reverts this MIB change?

I hope updating the MIB can be done pretty quick. Upstream got the
authorisation from the original MIB author to assign the ownership to the
net-snmp project. However, yet another bug (#274624) was opened and needs
to be addressed for sarge. I plan to make an high priority upload as soon
as the MIB issue is resolved or end of this week (whatever happens
earlier) to close this bug.

Thanks,
Jochen

[Andreas Barth (aba)]

Hi,

how wrote at October 3rd that you'll do an upload soon. What's the
status of that?

Cheers,
Andi
--
   http://home.arcor.de/andreas-barth/
   PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 15 Oct 2004 15:35:32 +0200
From: Andreas Barth <email address hidden>
To: <email address hidden>
Subject: Fixing upload?

Hi,

how wrote at October 3rd that you'll do an upload soon. What's the
status of that?

Cheers,
Andi
--
   http://home.arcor.de/andreas-barth/
   PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C

[Jochen Friedrich (jochen)]

tags 249904 +sarge
thanks

> how wrote at October 3rd that you'll do an upload soon. What's the
> status of that?

It's done. 5.1.2-6 is in unstable since Tuesday.

I just keep this bug open as the MIB patch has been reverted for now. It's
pending upstream because just last week an implementation for this MIB
popped up for solaris, and this has to be updated, as well.

Thanks,
Jochen

[Andreas Barth (aba)]

* Jochen Friedrich (<email address hidden>) [041015 21:40]:
> It's done. 5.1.2-6 is in unstable since Tuesday.

Thanks.

Cheers,
Andi
--
   http://home.arcor.de/andreas-barth/
   PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C

[Debian Bug Importer (debzilla)]

Message-ID: <Pine.LNX.4.58.0410152117440.21372@localhost>
Date: Fri, 15 Oct 2004 21:20:17 +0200 (CEST)
From: Jochen Friedrich <email address hidden>
To: Andreas Barth <email address hidden>, <email address hidden>
Cc: <email address hidden>
Subject: Re: Bug#249904: Fixing upload?

tags 249904 +sarge
thanks

> how wrote at October 3rd that you'll do an upload soon. What's the
> status of that?

It's done. 5.1.2-6 is in unstable since Tuesday.

I just keep this bug open as the MIB patch has been reverted for now. It's
pending upstream because just last week an implementation for this MIB
popped up for solaris, and this has to be updated, as well.

Thanks,
Jochen

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Fri, 15 Oct 2004 21:49:23 +0200
From: Andreas Barth <email address hidden>
To: Jochen Friedrich <email address hidden>, <email address hidden>
Subject: Re: Bug#249904: Fixing upload?

* Jochen Friedrich (<email address hidden>) [041015 21:40]:
> It's done. 5.1.2-6 is in unstable since Tuesday.

Thanks.

Cheers,
Andi
--
   http://home.arcor.de/andreas-barth/
   PGP 1024/89FB5CE5 DC F1 85 6D A6 45 9C 0F 3B BE F1 D0 C5 D1 D9 0C

[Steve Langasek (vorlon)]

severity 249904 important
tags 249904 -sarge
thanks

Version 5.1.2-6 of snmpd has reached testing. AIUI, the remaining bug is
not release-critical.

Thanks,
--
Steve Langasek
postmodern programmer

[Debian Bug Importer (debzilla)]

Message-ID: <email address hidden>
Date: Tue, 19 Oct 2004 19:14:38 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: Re: illegal modification of LM-SENSORS MIB

severity 249904 important
tags 249904 -sarge
thanks

Version 5.1.2-6 of snmpd has reached testing. AIUI, the remaining bug is
not release-critical.

Thanks,
--
Steve Langasek
postmodern programmer

[Peter Hirdina (peter-hirdina)]

Hi,

first I have to apologize, because after the notification that the was
rejected upstream, I kept my changes locally and forgot completely that
this bug is still open. And as I can see caused quite some work on your
side.

Anyway, I did rework my patch so it extends the LM-SENSORS MIB instead
of changing the existing entries. If the are some naming conventions the
names of these new values violate, feel free to change the names.

Attached is the patch against the current stable version (5.2.3-7).

cheers,
    Peter

---------------------------------------------------------------------
  Peter Hirdina Frauenstrasse 128
  <email address hidden> 89073 Ulm / Germany
---------------------------------------------------------------------

[Peter Hirdina (peter-hirdina)]

Hi again,

here is the patch now for real.

cheers,
    Peter

---------------------------------------------------------------------
  Peter Hirdina Frauenstrasse 128
  <email address hidden> 89073 Ulm / Germany
---------------------------------------------------------------------

[Sandro Tosi (morph-debian)]

# forwarded is to link remote bts, not upstream project homepage
notforwarded 268356
notforwarded 267290
notforwarded 252893
notforwarded 249904