mtr 0.86 doesn't respect terminal colors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
mtr (Debian) |
Fix Released
|
Unknown
|
|||
mtr (Ubuntu) |
Fix Released
|
Undecided
|
Adam Conrad | ||
Xenial |
Fix Released
|
Undecided
|
Adam Conrad |
Bug Description
[ SRU Justification ]
mtr 0.86 added more colours to the curses output, but this broke how it blends in with dark terminals with non-standard colours, and light terminals in general.
While this is purely cosmetic, it's pretty ugly compared to mtr 0.85, and the fix is trivial and trivially verified as correct (or, more correct than 0.86) on several different terminal colour schemes. As a man who uses mtr daily, it's been driving me mildly nuts.
[ Solution ]
Two commits upstream fix this, so it's a little more readable again on light terminals, and doesn't mess with non-standard terminals:
63a1f1493bfbaf7
7571201cf7a3394
[ Test Case ]
Run old and new mtr on a variety of terminal schemes (default gnome-terminal, inverted gnome-terminal, default and inverted xterm, etc) to see if it's (a) as readable or more than before, (b) now shows sanely default bg colours, (c) works correctly with transparent backgrounds.
The first point is somewhat subjective, though a quick test here shows that on "xterm -rv", the bold text has switched from some barely-readable grey-on-white to something approaching black-on-white, so I think this is moving in a winning direction.
Changed in mtr (Ubuntu): | |
status: | New → Fix Committed |
Changed in mtr (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in mtr (Ubuntu): | |
assignee: | nobody → Adam Conrad (adconrad) |
Changed in mtr (Ubuntu Xenial): | |
assignee: | nobody → Adam Conrad (adconrad) |
Changed in mtr (Debian): | |
status: | Unknown → New |
Changed in mtr (Debian): | |
status: | New → Fix Released |
Hello Adam, or anyone else affected,
Accepted mtr into xenial-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ mtr/0.86- 1ubuntu0. 1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!