Debian
mozilla package

mozilla: FTBFS: change in behavior of __attribute__((unused))

Bug #20532 reported by Debian Bug Importer
4
Affects Status Importance Assigned to Milestone
mozilla (Debian)
Fix Released
Unknown
mozilla (Ubuntu)
Invalid
High
Adam Conrad

Bug Description

Automatically imported from Debian bug report #325532 http://bugs.debian.org/325532

See original description

CVE References

Revision history for this message
In , Steve Langasek (vorlon) wrote : clone for thunderbird and firefox

clone 325532 -1 -2
reassign -1 mozilla-firefox/1.0.4-2
reassign -2 mozilla-thunderbird/1.0.2-3
thanks

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Automatically imported from Debian bug report #325532 http://bugs.debian.org/325532

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (5.2 KiB)

Message-ID: <email address hidden>
Date: Mon, 29 Aug 2005 02:07:51 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: mozilla: FTBFS: change in behavior of __attribute__((unused))

--XMCwj5IQnwKtuyBG
Content-Type: multipart/mixed; boundary="ftEhullJWpWg/VHq"
Content-Disposition: inline

--ftEhullJWpWg/VHq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: mozilla
Severity: serious

The current mozilla package fails to build on alpha, arm, and ia64
because it uses __attribute__((unused)) to mark static functions that
are called only from assembly routines. As of gcc 3.1,
__attribute__((used)) exists for marking static functions that are used;
as of gcc 4.0, __attribute__((unused)) still suppresses compiler
warnings about unused static functions, but it does *not* prevent the
compiler from optimizing them away.

The attached patch should fix this failure for all three architectures.
It has only been tested on alpha, and each architecture has its own
implementation for this bit of code, but this patch fixes all uses of
__attribute__((unused)), so it should be sufficient. (FWIW, one other
architecture -- i386 -- already uses ((used)) in the code...)

Since this bug is in the XPCOM code, it also affects other packages that
build copies of XPCOM. I'll clone this bug off to them as soon as I
have a bug number back.

Thanks,
--=20
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
<email address hidden> http://www.debian.org/

--ftEhullJWpWg/VHq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="mozilla-unused.diff"
Content-Transfer-Encoding: quoted-printable

diff -ur mozilla.orig/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_al=
pha.cpp=20
mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_alpha.cpp
--- mozilla.orig/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_alpha.c=
pp 2005-08-28 20:01:29.000000000 -0700
+++ mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_alpha.cpp 20=
05-08-28 02:36:43.000000000 -0700
@@ -43,7 +43,8 @@
 /* Prototype specifies unmangled function name and disables unused warning=
 */
 static void
 invoke_copy_to_stack(PRUint64* d, PRUint32 paramCount, nsXPTCVariant* s)
-__asm__("invoke_copy_to_stack") __attribute__((unused));
+__asm__("invoke_copy_to_stack") __attribute__((used));
+
=20
 static void
 invoke_copy_to_stack(PRUint64* d, PRUint32 paramCount, nsXPTCVariant* s)
diff -ur mozilla.orig/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp m=
ozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp
--- mozilla.orig/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp 2002-0=
3-04 22:35:50.000000000 -0800
+++ mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp 2005-08-28 =
02:46:41.000000000 -0700
@@ -45,7 +45,8 @@
 #endif
=20
 /* Specify explicitly a symbol for this function, don't try to guess the c=
++ mangled symbol. */
-static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 metho...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Mon, 29 Aug 2005 02:29:39 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: clone for thunderbird and firefox

clone 325532 -1 -2
reassign -1 mozilla-firefox/1.0.4-2
reassign -2 mozilla-thunderbird/1.0.2-3
thanks

Revision history for this message
In , Steve Langasek (vorlon) wrote :

reopen 325535
thanks

Sorry, the arm build of mozilla-firefox still fails, because the patch
for arm is on drugs:

+static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
+__attribute((used))__;

This last line should be

+__attribute__((used));

I have no idea why I wrote something that broken. :)

Good news is, alpha built fine. :)

Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
<email address hidden> http://www.debian.org/

Revision history for this message
In , Mike Hommey (mh-glandium) wrote : Re: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

On Wed, Sep 07, 2005 at 04:46:03AM -0700, Steve Langasek <email address hidden> wrote:
> reopen 325535
> thanks
>
> Sorry, the arm build of mozilla-firefox still fails, because the patch
> for arm is on drugs:
>
> +static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
> +__attribute((used))__;
>
> This last line should be
>
> +__attribute__((used));
>
> I have no idea why I wrote something that broken. :)
>
> Good news is, alpha built fine. :)

Note that, except for the arm one (the one who got b0rked ;) ), these
are fixed upstream in upcoming Firefox 1.5 beta, and is fixed on mozilla
1.8 branch, meaning next mozilla and thunderbird upstream releases will
also benefit from the fix. I will file this arm fix upstream.

Mike

Revision history for this message
In , Alexander Sack (asac) wrote : Re: Bug#325536: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

On Wed, Sep 07, 2005 at 06:07:02PM +0200, Mike Hommey wrote:
> 1.8 branch, meaning next mozilla and thunderbird upstream releases will
> also benefit from the fix. I will file this arm fix upstream.

Great, but don't forget to ask for review.

 - Alexander

 p.s. please take care that the bug is listed as To: or CC: when
      replying to this mail (e.g. /reply-all/).
--
 GPG messages preferred. | .''`. ** Debian GNU/Linux **
 Alexander Sack | : :' : The universal
 <email address hidden> | `. `' Operating System
 http://www.asoftsite.org | `- http://www.debian.org/

Revision history for this message
Fabio Massimo Di Nitto (fabbione) wrote :

this bug referes to an old version of firefox we don't ship in breezy.

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 7 Sep 2005 04:46:03 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Cc: <email address hidden>, <email address hidden>
Subject: Re: mozilla: FTBFS: change in behavior of __attribute__((unused))

--iFRdW5/EC4oqxDHL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

reopen 325535
thanks

Sorry, the arm build of mozilla-firefox still fails, because the patch
for arm is on drugs:

+static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodInde=
x, PRUint32* args) asm("_PrepareAndDispatch")
+__attribute((used))__;

This last line should be

+__attribute__((used));

I have no idea why I wrote something that broken. :)

Good news is, alpha built fine. :)

Cheers,
--=20
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
<email address hidden> http://www.debian.org/

--iFRdW5/EC4oqxDHL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDHtL7KN6ufymYLloRAjdeAKC5yohF5qf55/2a8VZFJR4Xg4d6fwCgvIWy
t6ZSNipfTESCtucSP7Sp4NA=
=2V+E
-----END PGP SIGNATURE-----

--iFRdW5/EC4oqxDHL--

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 7 Sep 2005 18:07:02 +0200
From: Mike Hommey <email address hidden>
To: Steve Langasek <email address hidden>, <email address hidden>
Cc: <email address hidden>, <email address hidden>
Subject: Re: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

On Wed, Sep 07, 2005 at 04:46:03AM -0700, Steve Langasek <email address hidden> wrote:
> reopen 325535
> thanks
>
> Sorry, the arm build of mozilla-firefox still fails, because the patch
> for arm is on drugs:
>
> +static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
> +__attribute((used))__;
>
> This last line should be
>
> +__attribute__((used));
>
> I have no idea why I wrote something that broken. :)
>
> Good news is, alpha built fine. :)

Note that, except for the arm one (the one who got b0rked ;) ), these
are fixed upstream in upcoming Firefox 1.5 beta, and is fixed on mozilla
1.8 branch, meaning next mozilla and thunderbird upstream releases will
also benefit from the fix. I will file this arm fix upstream.

Mike

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-ID: <email address hidden>
Date: Wed, 7 Sep 2005 20:25:13 +0200
From: Alexander Sack - Debian Bugmail <email address hidden>
To: Mike Hommey <email address hidden>, <email address hidden>
Cc: Steve Langasek <email address hidden>, <email address hidden>,
 <email address hidden>
Subject: Re: Bug#325536: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

On Wed, Sep 07, 2005 at 06:07:02PM +0200, Mike Hommey wrote:
> 1.8 branch, meaning next mozilla and thunderbird upstream releases will
> also benefit from the fix. I will file this arm fix upstream.

Great, but don't forget to ask for review.

 - Alexander

 p.s. please take care that the bug is listed as To: or CC: when
      replying to this mail (e.g. /reply-all/).
--
 GPG messages preferred. | .''`. ** Debian GNU/Linux **
 Alexander Sack | : :' : The universal
 <email address hidden> | `. `' Operating System
 http://www.asoftsite.org | `- http://www.debian.org/

Revision history for this message
In , Steve Langasek (vorlon) wrote : tagging 325532

# Automatically generated email from bts, devscripts version 2.9.7
tags 325532 patch

Revision history for this message
Debian Bug Importer (debzilla) wrote :

Message-Id: <email address hidden>
Date: Sun, 2 Oct 2005 23:12:22 -0700
From: Steve Langasek <email address hidden>
To: <email address hidden>
Subject: tagging 325532

# Automatically generated email from bts, devscripts version 2.9.7
tags 325532 patch

Revision history for this message
In , Alexander Sack (asac) wrote : Fixed in NMU of mozilla 2:1.7.12-1
Download full text (3.9 KiB)

tag 318723 + fixed
tag 321644 + fixed
tag 325532 + fixed
tag 327366 + fixed
tag 327455 + fixed
tag 329778 + fixed
tag 332480 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 6 Oct 2005 23:48:00 +0200
Source: mozilla
Binary: mozilla mozilla-calendar mozilla-dom-inspector libnspr4 mozilla-js-debugger mozilla-browser libnss3 libnspr-dev mozilla-chatzilla mozilla-psm mozilla-mailnews libnss-dev mozilla-dev
Architecture: source i386
Version: 2:1.7.12-1
Distribution: unstable
Urgency: high
Maintainer: Takuo KITAME <email address hidden>
Changed-By: Alexander Sack <email address hidden>
Description:
 libnspr-dev - Netscape Portable Runtime library - development files
 libnspr4 - Netscape Portable Runtime Library
 libnss-dev - Network Security Service Libraries - development
 libnss3 - Network Security Service Libraries - runtime
 mozilla - The Mozilla Internet application suite - meta package
 mozilla-browser - The Mozilla Internet application suite - core and browser
 mozilla-calendar - Todo organizer,calendar and reminder,integrated with Mozilla suit
 mozilla-chatzilla - Mozilla Web Browser - irc client
 mozilla-dev - The Mozilla Internet application suite - development files
 mozilla-dom-inspector - A tool for inspecting the DOM of pages in Mozilla.
 mozilla-js-debugger - JavaScript debugger for use with Mozilla
 mozilla-mailnews - The Mozilla Internet application suite - mail and news support
 mozilla-psm - The Mozilla Internet application suite - Personal Security Manage
Closes: 318723 321644 325532 327366 327455 329778 332480
Changes:
 mozilla (2:1.7.12-1) unstable; urgency=high
 .
   * NMU: fixing several security issues and most important RC bugs.
     (Closes: 332480)
   * new upstream version 1.7.12 fixes:
     + [CAN-2005-2871] IDN buffer overflow [MFSA 2005-57] (Closes: 327366)
     + security issue revealed: CAN-2005-2871 (Closes: 327455)
     + mozilla: Multiple security issues fixed in 1.7.12 (Closes: 329778)
     + javascript crasher - unsure about this ... have to test.
       (Closes: 318723)
     + mozilla 1.7.10 version crashes almost immediately (Closes: 321644)
   * applied patch by Steve Langasek <email address hidden> to make mozilla
     build on arm and other archs. (Closes: 325532)
Files:
 766dea59ec7f68b837ea0d42fd5a4188 1093 web optional mozilla_1.7.12-1.dsc
 6b5e421f09fef73ad972c8f6d7f7137b 30586755 web optional mozilla_1.7.12.orig.tar.gz
 0f7b83c1b25d5a6e3811c5d5add782ed 325638 web optional mozilla_1.7.12-1.diff.gz
 ad6d45717329823d52b98a7a5c9436ca 1022 web optional mozilla_1.7.12-1_i386.deb
 79c50292a9d41f7804c6b122d5989eec 9385338 web optional mozilla-browser_1.7.12-1_i386.deb
 d5b7b50bc5dd19ab8e8dc64aa05c12e9 3588608 devel optional mozilla-dev_1.7.12-1_i386.deb
 fdb59d0a9868df3d9bbaf72f3e997fab 1722632 mail optional mozilla-mailnews_1.7.12-1_i386.deb
 58cb2343e9d24d37ee35f596785fb5c3 158312 net optional mozilla-chatzilla_1.7.12-1_i386.deb
 b1e4b565ff92d53903726bf9ed5de29a 180280 web optional mozilla-psm_1.7.12-1_i386.deb
 b57fa3506af263edd8a6b464e8558605 115818 web optiona...

Read more...

Revision history for this message
Debian Bug Importer (debzilla) wrote :
Download full text (4.1 KiB)

Message-Id: <email address hidden>
Date: Sun, 09 Oct 2005 13:32:45 -0700
From: Alexander Sack <email address hidden>
To: <email address hidden>
Cc: Alexander Sack <email address hidden>, Takuo KITAME <email address hidden>
Subject: Fixed in NMU of mozilla 2:1.7.12-1

tag 318723 + fixed
tag 321644 + fixed
tag 325532 + fixed
tag 327366 + fixed
tag 327455 + fixed
tag 329778 + fixed
tag 332480 + fixed

quit

This message was generated automatically in response to a
non-maintainer upload. The .changes file follows.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 6 Oct 2005 23:48:00 +0200
Source: mozilla
Binary: mozilla mozilla-calendar mozilla-dom-inspector libnspr4 mozilla-js-debugger mozilla-browser libnss3 libnspr-dev mozilla-chatzilla mozilla-psm mozilla-mailnews libnss-dev mozilla-dev
Architecture: source i386
Version: 2:1.7.12-1
Distribution: unstable
Urgency: high
Maintainer: Takuo KITAME <email address hidden>
Changed-By: Alexander Sack <email address hidden>
Description:
 libnspr-dev - Netscape Portable Runtime library - development files
 libnspr4 - Netscape Portable Runtime Library
 libnss-dev - Network Security Service Libraries - development
 libnss3 - Network Security Service Libraries - runtime
 mozilla - The Mozilla Internet application suite - meta package
 mozilla-browser - The Mozilla Internet application suite - core and browser
 mozilla-calendar - Todo organizer,calendar and reminder,integrated with Mozilla suit
 mozilla-chatzilla - Mozilla Web Browser - irc client
 mozilla-dev - The Mozilla Internet application suite - development files
 mozilla-dom-inspector - A tool for inspecting the DOM of pages in Mozilla.
 mozilla-js-debugger - JavaScript debugger for use with Mozilla
 mozilla-mailnews - The Mozilla Internet application suite - mail and news support
 mozilla-psm - The Mozilla Internet application suite - Personal Security Manage
Closes: 318723 321644 325532 327366 327455 329778 332480
Changes:
 mozilla (2:1.7.12-1) unstable; urgency=high
 .
   * NMU: fixing several security issues and most important RC bugs.
     (Closes: 332480)
   * new upstream version 1.7.12 fixes:
     + [CAN-2005-2871] IDN buffer overflow [MFSA 2005-57] (Closes: 327366)
     + security issue revealed: CAN-2005-2871 (Closes: 327455)
     + mozilla: Multiple security issues fixed in 1.7.12 (Closes: 329778)
     + javascript crasher - unsure about this ... have to test.
       (Closes: 318723)
     + mozilla 1.7.10 version crashes almost immediately (Closes: 321644)
   * applied patch by Steve Langasek <email address hidden> to make mozilla
     build on arm and other archs. (Closes: 325532)
Files:
 766dea59ec7f68b837ea0d42fd5a4188 1093 web optional mozilla_1.7.12-1.dsc
 6b5e421f09fef73ad972c8f6d7f7137b 30586755 web optional mozilla_1.7.12.orig.tar.gz
 0f7b83c1b25d5a6e3811c5d5add782ed 325638 web optional mozilla_1.7.12-1.diff.gz
 ad6d45717329823d52b98a7a5c9436ca 1022 web optional mozilla_1.7.12-1_i386.deb
 79c50292a9d41f7804c6b122d5989eec 9385338 web optional mozilla-browser_1.7.12-1_i386.deb
 d5b7b50bc5dd19ab8e8dc64aa05c12e9 3588608 devel optional mozilla-dev_1.7.12-1_i386.deb
 fdb59d0a9868df3d9bbaf72f3e997fab 1722632 mail ...

Read more...

Revision history for this message
In , Adam D. Barratt (debian-bts-adam-barratt) wrote : Bugs fixed in NMU, documenting versions

# Hi,
#
# These bugs were fixed in an NMU, but have not been acknowledged by the
# maintainers. With version tracking in the Debian BTS, it is important
# to know which version of a package fixes each bug so that they can be
# tracked for release status, so I'm closing these bugs with the
#relevant version information now

close 271427 8.14+v8.11+urw-0.1
close 314698 0.35-2.1
close 325635 0.35-2.1
close 328017 0.35-2.1
close 320115 2.0-4.2
close 320284 1.11
close 320899 11.4.1870-7.1
close 327078 11.4.1870-7.1
close 327349 11.4.1870-7.1
close 320903 1:0.71-1.2
close 327946 1:0.71-1.2
close 320941 2.0.3-1.1
close 321126 2.6.3.2
close 321545 0.1.3b-1.1
close 341341 0.1.3b-1.1
close 321553 0.1.12-2.2
close 321644 2:1.7.12-1.1
close 346013 2:1.7.12-1.1
close 321816 2.61-2.1
close 321967 4.0.0-2.1
close 330024 4.0.0-2.1
close 321998 0.9.21-0.1
close 322583 0.3.8.1-4
close 322853 0.7.1-3.1
close 356739 0.7.1-3.1
close 322961 0.4.3.1.dfsg-0.1
close 322972 9.4.2-2.4
close 323084 0.4.5+cvs20030824-1.4
close 323160 0.1.10-0.1
close 323355 1.2.11-0.2
close 323725 0.18.2-10.1
close 323942 0.4.0-4.1
close 324371 4.3-18.1
close 324553 2.9.5.0.37.5.2
close 324558 1.2-release-2.1
close 324579 1.11-6.2
close 324606 1.2-release-2.2
close 324908 0.12.4-4.1
close 325210 2.6.0-1.1
close 325490 0.7.1-1.1
close 325514 0.8.6-1.1
close 326468 0.8.6-1.1
close 325532 2:1.7.12-1
close 327366 2:1.7.12-1
close 329778 2:1.7.12-1
close 332480 2:1.7.12-1
close 325635 0.35-2.1
close 328017 0.35-2.1
close 325835 0.1.12-7.1
close 325851 2:1.7.8-1sarge2
close 325938 0.9.8beta2-4.1
close 327930 0.9.8beta2-4.1
close 326285 0.99.3-5.1
close 326295 0.8.2-5.1
close 373110 0.8.2-5.1
close 379331 0.8.2-5.1
close 379334 0.8.2-5.1
close 326298 0.2.12-2.1
close 326311 0.3.5-1pre1.1
close 326355 2.1.8-2.1
close 326362 0.6-7.2
close 326371 0.90beta1-10.1
close 326372 1.0-0.1
close 326378 0.1.17-4.3
close 326466 6.3.2-2.1
close 347129 6.3.2-2.1
close 347205 6.3.2-2.1
close 326489 0.3.7-2.1
close 326756 1.0.9-1.1
close 365518 1.0.9-1.1
close 327429 1.2-1.1
close 350429 1.2-1.1
close 327911 2.3.5-1.1
close 327718 0.6.0-8.2
close 327933 0.9.2-1.1
close 327936 0.8.5-1.1
close 327970 0.5.1-2.1
close 327984 1.3-2.1
close 327986 0.2.36-4.1
close 291328 0.2.36-4.1
close 327996 1.0-1.1
close 328002 1.0.0-9.1
close 328018 2.1.3-2.1
close 328039 1.18A-2.1
close 328172 1.002-0.2
close 328333 4.1.2-1.1
close 328334 1.34-7.1
close 328335 0.8.2-2.1
close 328352 0.13-3.1
close 328364 0.4.0-test5-2.1
close 329467 1.3.1
close 330446 0.1.83
close 333857 0.1.83
close 330666 6:6.2.4.5-0.2
close 330938 0.5.1-2.2

Bug Watch Updater (bug-watch-updater)
Changed in mozilla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.