042_treeview_single_focus.patch change creates selection issues

[muntyan]

From changelog:

  * 042_treeview_single_focus.patch: don't select the focused item for
    GTK_SELECTION_SINGLE type treeviews. Allows the fix in
    040_filechooser_single-click.patch to work.

This change breaks Preferences dialog in medit, see the second part of https://bugs.launchpad.net/ubuntu/+source/medit/+bug/212433.

[Sebastien Bacher (seb128)]

thank you for your bug report, the patch comes from debian maybe you could open the bug on bugs.debian.org too?

[muntyan (muntyan)]

Is it necessary? I'd prefer not to deal with debian bug submission system.

[Sebastien Bacher (seb128)]

that's not required no, we can do it, do you have an easy testcase showing the issue? that would make debugging easier

[muntyan (muntyan)]

I think this will reproduce the problem. On unpatched gtk when the window pops up, the first row is selected. I believe nothing will be selected on ubuntu.

[MoMaT (momat)]

Confirming the test case. First element has focus but is not selected. Using libgtk2 2.12.9-3ubuntu2 in Hardy.

[Sebastien Bacher (seb128)]

bug sent to debian on http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=482966

[Sebastien Bacher (seb128)]

debug bug comment

"Selecting nothing is the correct behavior. Otherwise, when you use
keyboard navigation, you’ll end up changing the selection when you
navigate on the treeview. See
http://bugzilla.gnome.org/show_bug.cgi?id=492206 for the explanations.

If you want to force something to be selected, use gtk.SELECTION_BROWSE."

[muntyan (muntyan)]

Another comment, "The behavior has been like this since the very beginning, I don't really fancy changing it at this point ...", how about that? Or where is it documented that initial selection must be empty?

But it's an academic exercise to try to decide what's correct and what's not. For me Debian breaking my application is enough reason to change the code, I don't care if it's right for some people or not. But man, you should know by now that working around FileChooser bugs and deficiencies by changing code used everywhere is no good. You know discarding data in cell rendererers on focus-out thing?

[Sebastien Bacher (seb128)]

maybe you could send your comment by mail on <email address hidden> so they will go on the debian bug or comment on the upstream bugzilla?