Package requires network access during the build

Bug #1935066 reported by Athos Ribeiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
golang-github-go-sourcemap-sourcemap (Debian)
Fix Released
Unknown
golang-github-go-sourcemap-sourcemap (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

golang-github-go-sourcemap-sourcemap accesses the network during the build to fetch jquery files, as seen in [1].

While patching the test suite to use libjs-jquery from the archive could be an option, adjusting the tests would require previous knowledge of the specific jquery version in the archive, meaning the patch would need adjustments whenever jquery gets updated. A better fix could be to just stop running the test suite for this package build.

[1] https://launchpad.net/ubuntu/+source/golang-github-go-sourcemap-sourcemap/2.1.3+git20201028.eed1c20-2/+build/21478511

Tags: patch
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This patch disables the test suite so we can get a build without requiring network access.

A PPA with the patch is available at

https://launchpad.net/~athos-ribeiro/+archive/ubuntu/golang-github-go-sourcemap-sourcemap-no-tests/+packages

The patch was also submitted to debian at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989120

Changed in golang-github-go-sourcemap-sourcemap (Debian):
status: Unknown → New
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the patch, Athos. It LGTM.

Given that the same problem happens on Debian, and that incidentally I am part of the debian-go team and can upload the package, let's fix it there and then the package will automatically be sync'ed with Ubuntu.

Thanks again.

Changed in golang-github-go-sourcemap-sourcemap (Ubuntu):
status: New → Confirmed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "2-2.1.3+git20201028.eed1c20-2ubuntu1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in golang-github-go-sourcemap-sourcemap (Debian):
status: New → Fix Released
Mathew Hodson (mhodson)
Changed in golang-github-go-sourcemap-sourcemap (Ubuntu):
importance: Undecided → Low
Revision history for this message
Robie Basak (racb) wrote :

Unsubscribing sponsors as there is nothing left to sponsor.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

This has been sync'd from Debian, where the fix was applied.

Thanks, Sergio :)

Changed in golang-github-go-sourcemap-sourcemap (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.