no menu entry

[towsonu2003]

Binary package hint: gnome-chess

doesn't have a menu entry in Dapper

[Vassilis Pandis (pandisv)]

Confirmed on Feisty. gnome-chess includes a .desktop but it gets installed in /usr/share/gnome/apps/Games/gnome-chess.desktop and gnome doesn't find it.

[Adrien Cunin (adri2000)]

The Debian maintainer seems unresponsive. Vassilis: if you want to fix this bug, you can do it now.

[Siegfried Gevatter (rainct)]

Vassilis: Are you working on this?

[Miguel Ruiz (mruiz)]

It is possible to work on this bug ?

Thanks in advance!

[Siegfried Gevatter (rainct)]

I'd say, go on if you want :).

[Miguel Ruiz (mruiz)]

I'm working on it.

[Miguel Ruiz (mruiz)]

The solution is almost done. I have to fix a detail to upload my debdiff.

Greetings!

[Adam Sunderland (iterion)]

I have been working on a solution to this as well, as it seemed like an appropriate introduction into Ubuntu packaging. I don't mean to step on toes by uploading this before Miguel, but I figured I would since I believe I have fixed it.

I am unsure that this is the most elegant solution, but it works for me.

The debdiff is attached.

[Adam Sunderland (iterion)]

Nevermind, the patch doesn't work at all. I looked in my regular /usr/share instead of my chrooted environment. Ignore the last post.

Sorry for the spam.

[Miguel Ruiz (mruiz)]

I can't remember why I didn't upload my patch... anyway, it's here for a review.

Cheers!

[Luca Falavigna (dktrkranz)]

It seems candidate revision contains two .desktop files:

$ dpkg -c gnome-chess_0.3.3-6.1ubuntu1_i386.deb | grep desktop
-rw-r--r-- root/root 981 2008-01-21 20:47 ./usr/share/gnome/apps/Games/gnome-chess.desktop
-rw-r--r-- root/root 981 2008-01-21 20:46 ./usr/share/applications/gnome-chess.desktop
$

Could you please address this? Thanks.

[Miguel Ruiz (mruiz)]

Is valid to patch the following files? (drop the directory reference)

$ grep "/gnome/apps/Games/" * -R
gnome-chess.spec:%{prefix}/share/gnome/apps/Games/*
gnome-chess.spec.in:%{prefix}/share/gnome/apps/Games/*

Also, gnome-chess.desktop is the only file under /usr/share/gnome/apps/Games/.

Cheers!

[Adam Sunderland (iterion)]

I looked at the package, and to me it seems that the problem lies in the Makefile.in where there are these lines:

Icondir = $(datadir)/pixmaps
Mimedir = $(datadir)/mime-info
Gamesdir = $(datadir)/gnome/apps/Games

changing Gamesdir = $(datadir)/applications should solve the problem I think.

I'll do a build myself to make sure.

Adam

[Adam Sunderland (iterion)]

Yeah, I built my own version and that simple change is all that is really needed.

If you want me to provide you with a debdiff just let me know.

Adam

[Miguel Ruiz (mruiz)]

Thanks Adam and Luca for your guidance.

I'm attaching a new debdiff, without the problem:

mruiz@hardy:~$ dpkg -c pbuilder/result/gnome-chess_0.3.3-6.1ubuntu1_i386.deb |grep .desktop
-rw-r--r-- root/root 981 2008-01-22 10:09 ./usr/share/applications/gnome-chess.desktop

Cheers!

[Adam Sunderland (iterion)]

Perhaps I am wrong, since I am new at this also, but shouldn't the version be 0.3.3-6ubuntu1 instead of 0.3.3-6.1ubuntu1?

Since this is the first Ubuntu revision on top of the 6th debian revision?

[Siegfried Gevatter (rainct)]

2008/1/22, Adam Sunderland <email address hidden>:
> Shouldn't the version be 0.3.3-6ubuntu1 instead of 0.3.3-6.1ubuntu1?

No, the version is right. There is currently version 0.3.3-6.1build1
in Hardy, not 0.3.3-6 (which is the version in Gutsy).

[Luca Falavigna (dktrkranz)]

desktop-file-validate complains loudly, could you please check?

[Miguel Ruiz (mruiz)]

Luca:

I checked the gnome-chess.desktop with desktop-file-validate and I fixed the errors (It's a very good tool!).

I'm attaching a better patch ;-)

Cheers!

[Luca Falavigna (dktrkranz)]

Looks good now, thanks ;)

[Miguel Ruiz (mruiz)]

Finally I did it ;-)

Thanks everybody!

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-chess - 0.3.3-6.1ubuntu1

---------------
gnome-chess (0.3.3-6.1ubuntu1) hardy; urgency=low

  * debian/patches:
    + Added 022_menu_fix.diff to solve missing menu entry (LP: #89353).
    + Added 023_gnome-chess-desktop.diff to fix some problems as result
      of testing with desktop-file-validate.
  * debian/control:
    + Bumped Standards-Version to 3.7.3
    + Modified Maintainer value to match the DebianMaintainerField
      specification.

 -- Miguel Ruiz <email address hidden> Thu, 24 Jan 2008 01:00:33 -0300