FTBFS with GCC 4.4

[No]

Binary package hint: gnoemoe

Currently FTBFS:
http://launchpadlibrarian.net/31813021/buildlog_ubuntu-karmic-i386.gnoemoe_2.2.0%2Bdfsg-2_FAILEDTOBUILD.txt.gz

[No (11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

The above branch contains a fix.
You can find the diff here:
https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164/+merge/13854

[Fabrice Coutadeur (fabricesp)]

Hi,

As stated by James Westby in the merge review:

"Please see https://wiki.ubuntu.com/CompilerFlags for a recipe
for checking the return code of "write" fully."

So I'll put the bug report as incomplete. Please put back as Confirmed when this is fixed.

Fabrice

[No (11111nonononono-deactivatedaccount-deactivatedaccount-deactivatedaccount)]

Implemented. Please see the merge proposal for details.

Thanks
Simon

[Scott Kitterman (kitterman)]

[09:43:14] <ScottK> Would someone that knows C please review https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164/+merge/13854
[09:53:48] <joaopinto> ScottK, gint count = (strlen(no_ansi) - written); it could use just "len" no need to call strlen() again
[09:54:17] <ScottK> joaopinto: Could you fix it and make a proper debbdiff?
[09:55:15] <joaopinto> well, it's a very small improvement, doesn't worth a debdiff at this time, the code looks sane
[09:56:20] <zooko> ScottK: something looks wrong to me.
[09:57:04] <zooko> Suppose strlen(no_ansi) is 20 at the start. written gets initialized to 0. First pass of the loop, count = 20
[09:57:20] <zooko> suppose partial write, written = 5, then
[09:57:41] <zooko> second pass of the loop, count = 15
[09:57:58] <zooko> so far so good -- it invokes write(fd, no_ansi+5, 15)
[09:58:10] <zooko> but if there is a second partial write, let's say this time written = 6
[09:58:33] <zooko> so 3rd pass of the loop, count = 14
[09:58:35] <joaopinto> oh written is not cumulative :\

[Scott Kitterman (kitterman)]

https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164/+merge/13854

[Didier Roche-Tolomelli (didrocks)]

Patch is good. Uploaded. Thanks Simon for you work there.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnoemoe - 2.2.0+dfsg-2ubuntu1

---------------
gnoemoe (2.2.0+dfsg-2ubuntu1) karmic; urgency=low

  * Fix FTBFS with GCC 4.4 (LP: #459164)

 -- Simon Olofsson <email address hidden> Mon, 26 Oct 2009 16:28:47 +0100