Activity log for bug #1901290

Date Who What changed Old value New value Message
2020-10-24 08:36:31 Timo Jyrinki bug added bug
2020-10-24 08:36:59 Timo Jyrinki bug watch added https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969441
2020-10-24 08:36:59 Timo Jyrinki bug task added enchant-2 (Debian)
2020-10-28 20:10:02 Sebastien Bacher enchant-2 (Ubuntu): importance Undecided Low
2020-10-28 20:12:37 Sebastien Bacher enchant-2 (Ubuntu): status New Fix Committed
2020-10-28 20:18:31 Sebastien Bacher bug added subscriber Sebastien Bacher
2020-10-28 20:18:35 Sebastien Bacher removed subscriber Sebastien Bacher
2020-10-29 08:59:45 Sebastien Bacher enchant-2 (Ubuntu): status Fix Committed Fix Released
2020-11-05 15:25:00 Timo Jyrinki description This shows up particularly with the inline checking feature of gspell in eg gedit which is part of the default Ubuntu installation. The issue is fixed in Enchant 2.2.12, and after that release reaches Debian and Ubuntu hirsute, I hope a backport of this patch to https://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch can be done to groovy and focal. SRU paperwork to be added later, but in general all backends would be good to test after the backport in various ways like gspell, sonnet, libreoffice. [Impact] Spell checking / spelling error highlighting does not work properly in eg gedit, gnote or gtranslator when using a language which uses Voikko (often Finnish, but also North Sámi (giella-sme package) or user installed HFST spellers like other Sámi languages or Greenlandic) or Zemberek (Turkish) backend via Enchant-2. [Test Case] (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10) 1. apt install libenchant-2-voikko voikko-fi 2. Run gedit, gnote, gtranslator or other gspell using program 3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish (suomi) as language 4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe for a comparison "tämmä on vihre" (1st and 3rd word incorrect) 5. Note how everything is underlined - in suggestions, you can choose the same word and the underlining disappears, but as soon as you eg "leave" the word (press space after it) it gets underlined again. However, if doing manual spell checking the words are correctly understood as being correct. [Regression Potential] The patch changes code only in voikko and zemberek backends, so regression potential would be very low outside of those, and Zemberek backend is currently disabled by default in Debian and Ubuntu. Voikko backend would be good to test via multiple libraries like gspell, gtkspell, sonnet that there are no regressions. --- original report --- This shows up particularly with the inline checking feature of gspell in eg gedit which is part of the default Ubuntu installation. The issue is fixed in Enchant 2.2.12, and after that release reaches Debian and Ubuntu hirsute, I hope a backport of this patch to https://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch can be done to groovy and focal. SRU paperwork to be added later, but in general all backends would be good to test after the backport in various ways like gspell, sonnet.
2020-11-05 15:25:26 Timo Jyrinki bug added subscriber Ubuntu Stable Release Updates Team
2020-11-05 15:25:38 Timo Jyrinki summary Enchant-2 does not work properly with backends that want a NUL-terminated string [SRU] Enchant-2 does not work properly with backends that want a NUL-terminated string
2020-11-09 11:36:17 Timo Jyrinki description [Impact] Spell checking / spelling error highlighting does not work properly in eg gedit, gnote or gtranslator when using a language which uses Voikko (often Finnish, but also North Sámi (giella-sme package) or user installed HFST spellers like other Sámi languages or Greenlandic) or Zemberek (Turkish) backend via Enchant-2. [Test Case] (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10) 1. apt install libenchant-2-voikko voikko-fi 2. Run gedit, gnote, gtranslator or other gspell using program 3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish (suomi) as language 4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe for a comparison "tämmä on vihre" (1st and 3rd word incorrect) 5. Note how everything is underlined - in suggestions, you can choose the same word and the underlining disappears, but as soon as you eg "leave" the word (press space after it) it gets underlined again. However, if doing manual spell checking the words are correctly understood as being correct. [Regression Potential] The patch changes code only in voikko and zemberek backends, so regression potential would be very low outside of those, and Zemberek backend is currently disabled by default in Debian and Ubuntu. Voikko backend would be good to test via multiple libraries like gspell, gtkspell, sonnet that there are no regressions. --- original report --- This shows up particularly with the inline checking feature of gspell in eg gedit which is part of the default Ubuntu installation. The issue is fixed in Enchant 2.2.12, and after that release reaches Debian and Ubuntu hirsute, I hope a backport of this patch to https://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch can be done to groovy and focal. SRU paperwork to be added later, but in general all backends would be good to test after the backport in various ways like gspell, sonnet. [Impact] Spell checking / spelling error highlighting does not work properly in eg gedit, gnote or gtranslator when using a language which uses Voikko (often Finnish, but also North Sámi (giella-sme package) or user installed HFST spellers like other Sámi languages or Greenlandic) or Zemberek (Turkish) backend via Enchant-2. [Test Case] (from https://gitlab.gnome.org/GNOME/gspell/-/issues/10) 1. apt install libenchant-2-voikko voikko-fi 2. Run gedit, gnote, gtranslator or other gspell using program 3. (in gedit) Enable underlining of incorrectly typed words, and set Finnish (suomi) as language 4. Copy-paste for example "tämä on testitekstiä" ("this is test text"), maybe for a comparison "tämmä on vihre" (1st and 3rd word incorrect) 5. Note how everything is underlined - in suggestions, you can choose the same word and the underlining disappears, but as soon as you eg "leave" the word (press space after it) it gets underlined again. However, if doing manual spell checking the words are correctly understood as being correct. [Where problems could occur] The patch changes code in voikko and zemberek plugins, which are built and shipped separately. Zemberek is not built at all in Debian or Ubuntu. Thus, no changes (or problems) should be possible to happen outside the Voikko plugin (libenchant-2-voikko binary package), unless a toolchain change since the last build in March 2020 would cause a change with unchanged source. Voikko plugin would be good to test via multiple libraries like gspell, gtkspell, sonnet that there are no regressions. --- original report --- This shows up particularly with the inline checking feature of gspell in eg gedit which is part of the default Ubuntu installation. The issue is fixed in Enchant 2.2.12, and after that release reaches Debian and Ubuntu hirsute, I hope a backport of this patch to https://patch-diff.githubusercontent.com/raw/AbiWord/enchant/pull/260.patch can be done to groovy and focal. SRU paperwork to be added later, but in general all backends would be good to test after the backport in various ways like gspell, sonnet.
2020-11-09 11:37:27 Timo Jyrinki nominated for series Ubuntu Groovy
2020-11-09 11:37:27 Timo Jyrinki bug task added enchant-2 (Ubuntu Groovy)
2020-11-09 11:37:27 Timo Jyrinki nominated for series Ubuntu Focal
2020-11-09 11:37:27 Timo Jyrinki bug task added enchant-2 (Ubuntu Focal)
2020-11-09 11:37:42 Timo Jyrinki enchant-2 (Ubuntu Focal): importance Undecided Low
2020-11-09 11:37:44 Timo Jyrinki enchant-2 (Ubuntu Groovy): importance Undecided Low
2020-11-09 22:31:38 Sebastien Bacher enchant-2 (Ubuntu Focal): status New Fix Committed
2020-11-09 22:31:40 Sebastien Bacher enchant-2 (Ubuntu Groovy): status New Fix Committed
2020-11-09 22:31:46 Sebastien Bacher enchant-2 (Ubuntu Focal): assignee Timo Jyrinki (timo-jyrinki)
2020-11-09 22:31:50 Sebastien Bacher enchant-2 (Ubuntu Groovy): assignee Timo Jyrinki (timo-jyrinki)
2020-11-10 17:55:00 Brian Murray bug added subscriber SRU Verification
2020-11-10 17:55:18 Brian Murray tags verification-needed verification-needed-groovy
2020-11-10 17:56:06 Brian Murray tags verification-needed verification-needed-groovy verification-needed verification-needed-focal verification-needed-groovy
2020-11-11 10:01:44 Timo Jyrinki attachment added enchant-validation.png https://bugs.launchpad.net/debian/+source/enchant-2/+bug/1901290/+attachment/5433301/+files/enchant-validation.png
2020-11-11 10:01:59 Timo Jyrinki tags verification-needed verification-needed-focal verification-needed-groovy verification-done verification-done-focal verification-done-groovy
2020-11-17 23:42:04 Launchpad Janitor enchant-2 (Ubuntu Groovy): status Fix Committed Fix Released
2020-11-17 23:42:11 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2020-11-17 23:42:39 Launchpad Janitor enchant-2 (Ubuntu Focal): status Fix Committed Fix Released
2021-02-25 12:21:27 Bug Watch Updater enchant-2 (Debian): status Unknown Fix Released