dh-make-golang 0.6.0-2 fails to build from source

Bug #2046369 reported by Benjamin Drung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dh-make-golang (Debian)
Fix Released
Unknown
dh-make-golang (Ubuntu)
Fix Released
Undecided
Dominik Viererbe

Bug Description

dh-make-golang 0.6.0-2 fails to build from source:

```
   dh_auto_build -O--builddirectory=_build -O--buildsystem=golang
dh_auto_build: warning: LTO optimize is enable in buildflags. But cgo doesn't support it. LTO flags will be stripped in cgo.
 cd _build && go install -trimpath -v -p 4 github.com/Debian/dh-make-golang
src/github.com/Debian/dh-make-golang/check_depends.go:6:2: cannot find package "golang.org/x/tools/go/vcs" in any of:
 /usr/lib/go-1.21/src/golang.org/x/tools/go/vcs (from $GOROOT)
 /<<PKGBUILDDIR>>/_build/src/golang.org/x/tools/go/vcs (from $GOPATH)
dh_auto_build: error: cd _build && go install -trimpath -v -p 4 github.com/Debian/dh-make-golang returned exit code 1
make: *** [debian/rules:6: binary] Error 25
```

Full log: https://launchpadlibrarian.net/702059009/buildlog_ubuntu-noble-amd64.dh-make-golang_0.6.0-2build1_BUILDING.txt.gz

Related branches

Changed in dh-make-golang (Debian):
status: Unknown → New
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

I am currently looking into this on my +1 shift. I already tried to disable lto, because of the warning:
> dh_auto_build: warning: LTO optimize is enable in buildflags. But cgo doesn't support it. LTO flags will > be stripped in cgo.

Unfortunately this did not solve it and I have no experience with go, so I may have to ask @zhsj what could cause the error: cannot find package "golang.org/x/tools/go/vcs"

Changed in dh-make-golang (Debian):
status: New → Fix Released
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

I got a passing build of dh-make-golang - 0.7.0-1 with golang-github-google-go-github 60.0.0-1. See [1].

Actions to take:
1. Sync golang-github-google-go-github 60.0.0-1 from debian unstable
2. Sync dh-make-golang - 0.7.0-1 from debian unstable

[1] https://launchpad.net/~dviererbe/+archive/ubuntu/lp2046369/+packages

Changed in dh-make-golang (Ubuntu):
status: New → In Progress
Revision history for this message
Dominik Viererbe (dviererbe) wrote :

$ reverse-depends --release noble --arch=source src:golang-github-google-go-github
Reverse-Build-Depends
=====================
* bettercap (for golang-github-google-go-github-dev)
* dh-make-golang (for golang-github-google-go-github-dev)
* distrobuilder (for golang-github-google-go-github-dev)
* golang-github-weppos-publicsuffix-go
* golang-github-zitadel-oidc (for golang-github-google-go-github-dev)

$ reverse-depends --release noble --arch=source src:bettercap
No reverse dependencies found

$ reverse-depends --release noble --arch=source src:dh-make-golang
No reverse dependencies found

$ reverse-depends --release noble --arch=source src:distrobuilder
No reverse dependencies found

$ reverse-depends --release noble --arch=source src:golang-github-weppos-publicsuffix-go
No reverse dependencies found

$ reverse-depends --release noble --arch=source src:golang-github-zitadel-oidc
Reverse-Build-Depends
=====================
* incus (for golang-github-zitadel-oidc-dev)

$ reverse-depends --release noble --arch=source src:incus
Reverse-Build-Depends
=====================
* distrobuilder (for golang-github-lxc-incus-dev)

$ reverse-depends --release noble --arch=source src:dh-make-golang
No reverse dependencies found

Note: I have the feeling that the reverse-depends output for src:dh-make-golang is just empty, because packages buikld depend on the Provides: dh-sequence-golang :/

Revision history for this message
Dominik Viererbe (dviererbe) wrote :

Rebuilding bettercap, distrobuilder, golang-github-weppos-publicsuffix-go against golang-github-google-go-github (60.0.0-1) resulted in build failures :/

Revision history for this message
Dominik Viererbe (dviererbe) wrote :

For some reason someone synced 0.7.0-1 and golang-github-google-go-github 60.0.0-1, so... my merge is no longer needed and this problem is solved.

Changed in dh-make-golang (Ubuntu):
status: In Progress → Fix Released
assignee: nobody → Dominik Viererbe (dviererbe)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.