confusing message about launchpad-login, even when doing readonly access to a public branch

[Erik de Castro Lopo]

Running the command:

      bzr branch lp:bzr-fastimport fastimport

I first of all got the error message:

    You have not informed bzr of your launchpad login. If you are attempting a
    write operation and it fails, run "bzr launchpad-login YOUR_ID" and try again.

and then bzr seemed to hang. A minute or wto later it turns out that it hasn't hung and is happily pulling revisions.

I would suggest the following fixes:

   - If bzr knows that it is pulling and not writing, it should not mention 'write' in the error message.
   - If it is a pull operation, the warning should state something like:

        You have not informed bzr of your launchpad login therefore using http transport instead of bzr+ssh

[Martin Pool (mbp)]

I agree something like that message would be better, and it doesn't need any code changes.

How about "You have not informed bzr of your launchpad login therefore using anonymous readonly http transport instead of bzr+ssh"?

Or to be a bit more terse "No launchpad login set, therefore ...." That gives a clue to the command too.

I think we do want to convey that it's readonly.

There are other bugs about launchpad-login but this might be an easy win.

[Andrew Bennetts (spiv)]

I like the terse "No launchpad login set" form. "therefore" is a bit long, maybe just omit it or replace it with "so"? i.e. the full text would be:

"No launchpad login set, so using anonymous readonly http transport instead of bzr+ssh".

Any of the proposed variations would be a big improvement though, so +1 on whatever wording Martin likes :)

[Erik de Castro Lopo (erikd)]

Martin Pool wrote:

> I agree something like that message would be better, and it doesn't need
> any code changes.
>
> How about "You have not informed bzr of your launchpad login therefore
> using anonymous readonly http transport instead of bzr+ssh"?
>
> Or to be a bit more terse "No launchpad login set, therefore ...." That
> gives a clue to the command too.

Either of those would be fine.

Cheers,
Erik
--
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

[danstowell (danstowell)]

This issue just affected me, I was troubleshooting a complex auto-install and spent a while investigating the wrong thing thanks to the current message :)

It's an easy fix but still seems to be open. It gets my vote. I just downloaded the bzr trunk of bzr and grepped around but I couldn't work out where the strings are defined - could someone tell me please, and I'll send a patch?

[Martin Pool (mbp)]

On 20 June 2010 20:40, danstowell <email address hidden> wrote:
> This issue just affected me, I was troubleshooting a complex auto-
> install and spent a while investigating the wrong thing thanks to the
> current message :)
>
> It's an easy fix but still seems to be open. It gets my vote. I just
> downloaded the bzr trunk of bzr and grepped around but I couldn't work
> out where the strings are defined - could someone tell me please, and
> I'll send a patch?

If you just want to change the string, it's in
bzrlib/plugins/launchpad/lp_directory.py

However a real fix for this bug probably requires teaching bzr whether
it's going to need read access or read/write access at the moment it
opens the transport. That will also make some other messages clearer
including one about locking over http. You could start an rfc thread
to ask whether people see any problems with this. Perhaps we would
want get_transport(...readonly=True) and then we can give the warning
about Launchpad only in the case that is true.

--
Martin

[Daniel Hahler (blueyed)]

Please allow suppressing this message altogether, e.g. by using "-q / --quiet".

This would allow me to have cleaner cron emails, without suppressing bzr output altogether.

[Andrew Starr-Bochicchio (andrewsomething)]

Similar request in Debian #693832:

"I'd be really grateful if the nagging would be quiesced, whenever the
URL is (usually) RO, or if it can get mapped to an RO one (like “lp:”
ones). Or at least if I could tell bzr somehow (suppress_warnings?),
I'm not intersted in registering on Launchpad."