Add LOGO to /etc/os-release

Bug #1931582 reported by Marco Trevisan (Treviño)
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
base-files (Debian)
New
Unknown
base-files (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

/etc/os-release can provide a logo file, this is now used by gnome-control-center to show the logo into the info panel.

If ubuntu would provide its logo name in such file we would be able to remove the downstream patch that forces the usage of /usr/share/pixmaps/ubuntu-logo-icon.png

References
-----------
https://www.freedesktop.org/software/systemd/man/os-release.html

https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/985
GNOME Control Center, as of version 41, can look for variations of the named LOGO. So we should offer those variations if possible too.

description: updated
Changed in base-files (Debian):
status: Unknown → New
Revision history for this message
Jeremy Bícha (jbicha) wrote :

What package would contain the distro logos? Would we need to have base-files Depend on that package?

description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

It's also unclear from upstream discussion what should be the format of the image

Changed in base-files (Ubuntu):
importance: Medium → Wishlist
Revision history for this message
Robert Ancell (robert-ancell) wrote :

The format seems clear, from the os-release spec:

"...the name of an icon as defined by freedesktop.org Icon Theme Specification"

Revision history for this message
Sebastien Bacher (seb128) wrote :

I meant it's unclear if what sort of logo it should be. Square image only? Text+logo as on plymouth? The GNOME settings upstream discussion mention text and black variants...

After discussing with Robert it seems that's intended for the 'simple' logo, so squared icon. Unsure if the variants are standardized but the GNOME ticket lists logo-text/logo-dark/logo-text-dark so maybe should also be provided

Revision history for this message
Sebastien Bacher (seb128) wrote :

Checking that topic again, fedora added back a patch stating they don't think the upstream solution is enough
https://src.fedoraproject.org/rpms/gnome-control-center/blob/rawhide/f/distro-logo.patch

The discussion continued upstream in https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/965

and then https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1399

Changed in base-files (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package base-files - 12.2ubuntu2

---------------
base-files (12.2ubuntu2) kinetic; urgency=medium

  * debian/rules, etc/os-release, logos/:
    - set a LOGO=ubuntu-logo key which is part of the specification,
      install ubuntu-logo/-text/-text-dark icons (lp: #1931582)

 -- Sebastien Bacher <email address hidden> Mon, 11 Jul 2022 17:58:15 +0200

Changed in base-files (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.