/etc/os-release: Please specify VERSION_CODENAME

[Benjamin Drung]

[ SRU Justification ]
UBUNTU_CODENAME was added by the snapd team, then proposed upstream in a more generic way. Upstream settled on VERSION_CODENAME, and we should include that as well, in case third party (or, indeed, future versions of our own) software decide to start looking for it.

[ SRU Test Case ]
Check diffs of both source package and installed os-release, make sure nothing's changed except VERSION_CODENAME, and that the value is correct.

[ Regression Potential ]
Nein.

[ Original Report ]
The os-release specification was updated in systemd > 230 to also include a VERSION_CODENAME parameter: https://github.com/systemd/systemd/commit/646b997c118e261c5ececc434dd40d0dbdbac4d8

Please replace the custom UBUNTU_CODENAME parameter by VERSION_CODENAME in yakkety and add VERSION_CODENAME to /etc/os-release to all stable releases.

[Martin Pitt (pitti)]

This warrants an archive grep for UBUNTU_CODENAME first; I think Michael Vogt added that the other day, so presumably it's being used in snappy? So for the time being it'd be better to have both until users of UBUNTU_CODENAME get updated.

[Steve Langasek (vorlon)]

should be an addition of VERSION_CODENAME in yakkety rather than a straight replace. snapd, for instance, consumes UBUNTU_CODENAME, since it's the only field in /etc/os-release with this information currently....

[Adam Conrad (adconrad)]

Likely need to keep both UBUNTU_CODENAME and VERSION_CODENAME in xenial forever, to avoid having to add a (very) icky "Breaks: snapd (<< fixed-version)" to base-files when we remove it.

Though, in the interest of correctness, I suppose that Breaks would also be necessary in yakkety, but maybe we can get away with handwaving past it, if it doesn't critically break snapd on upgrade.

[Steve Langasek (vorlon)]

Hello Benjamin, or anyone else affected,

Accepted base-files into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/base-files/9.4ubuntu4.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Michael Vogt (mvo)]

We removed looking for UBUNTU_CODENAME in d57b958d2c7a8deedd04223509f495f3978ca5f9. There is one leftover instance in our tests that uses it. I pushed a branch to snapd to kill that last usage as well.

[Launchpad Janitor (janitor)]

This bug was fixed in the package base-files - 9.6ubuntu3

---------------
base-files (9.6ubuntu3) yakkety; urgency=medium

  * /etc/os-release: Add VERSION_CODENAME per upstream spec (LP: #1598212)

 -- Adam Conrad <email address hidden> Fri, 12 Aug 2016 11:45:34 -0600

[Martin Pitt (pitti)]

I verified the xenial SRU: source and binary package diffs and resulting /etc/os-release is as expected:

VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

[Launchpad Janitor (janitor)]

This bug was fixed in the package base-files - 9.4ubuntu4.3

---------------
base-files (9.4ubuntu4.3) xenial; urgency=medium

  * /etc/os-release: Add VERSION_CODENAME per upstream spec (LP: #1598212)

 -- Adam Conrad <email address hidden> Fri, 12 Aug 2016 11:48:58 -0600

[Martin Pitt (pitti)]

The verification of the Stable Release Update for base-files has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.