Re: Bug#658730: Link hint with accesskey follow wrong link

[Yves-Alexis Perez]

 affects midori
 affects debian
 done

On dim., 2012-02-05 at 10:34 -0500, Joseph Nahmias wrote:
> Package: midori
> Version: 0.4.3-1
> Severity: normal
>
> Hello,
>
> I seem to have found a problem with the implementation of Link Hints in
> Midori. If a link has an accesskey attribute set, Midori (properly) uses
> that accesskey for the link hint. However, when choosing that link Midori
> follows the first link on the page rather than the one designated by the
> link hint.
>
> I've attached a (very) simple test page to demonstrate this. There are
> two links on the page: the first has no accesskey and goes to bad.html;
> the second has an accesskey of "f" and goes to good.html. When pressing
> '.', I correctly see the second link tagged with 'f'; however, if you
> press 'f' and then enter Midori goes to bad.html, instead of good.html.
>
> I haven't tested in the latest trunk, but please let me know if you think
> a fix has been commited and I'll do so.

Yes, confirmed here, forwarding upstream.
>
> --Joe
>
> -- System Information:
> Debian Release: wheezy/sid
> APT prefers testing
> APT policy: (990, 'testing'), (500, 'unstable'), (200, 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 3.2.0-rc7-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
>
> Versions of packages midori depends on:
> ii dbus-x11 1.4.16-1
> ii libc6 2.13-24
> ii libcairo2 1.10.2-6.2
> ii libgdk-pixbuf2.0-0 2.24.0-2
> ii libglib2.0-0 2.30.2-4
> ii libgtk2.0-0 2.24.8-3
> ii libjavascriptcoregtk-1.0-0 1.6.1-5+b1
> ii libnotify4 0.7.4-1
> ii libpango1.0-0 1.29.4-2
> ii libsoup2.4-1 2.34.3-1
> ii libsqlite3-0 3.7.9-2
> ii libunique-1.0-0 1.1.6-4
> ii libwebkitgtk-1.0-0 1.6.1-5+b1
> ii libx11-6 2:1.4.4-4
> ii libxml2 2.7.8.dfsg-7
> ii libxss1 1:1.2.1-2
>
> Versions of packages midori recommends:
> ii gnome-icon-theme 3.2.1.2-1
>
> midori suggests no packages.
>
> -- no debconf information

--
Yves-Alexis

[Joe Nahmias (jello)]

I just stopped by this bug, and I noticed the patches that I sent a while back via email never made it to the bug tracker. So, I've attached them here manually. Let me know if you have any questions.

[Cris Dywan (kalikiana)]

Very nice patches. I like the refactoring. And the handling of access keys. There were minor stylistic deviations which I fixed (no C++ style comments, always space before bracket).