Comment 23 for bug 806291

Revision history for this message
Michael Nagel (nailor) wrote : Re: [needs-packaging] Boot-Repair

hmm... i don't see how to comment on the blueprint, so i put this here:

after looking at the code, i think you are basically doing exactly what i suggested.

i am not sure what Fabrice means with
- I've got the feeling that boot-repair have ot be launched as root. Is it the case? If so, you should use gksudo or equivalent in the .desktop files

if he means "the tool should be run as root, not as user" then this is already taken care of
if he means "the request for root privileges should be directly in the launcher" this is not yet the case, because root privileges are only requested in a subsequent script. i do not know desktop files well enough to tell if this is a problem, but i do not think so. if it is absolutely necessary to put "(gk)su(do) boot-repair" in the launcher, this should not hurt either. gui-g2slaunch.sh could either just do nothing if it is started with root privileges or it could (unnecessarily, but no harm) run (gk)su(do) once again...

but i still think everything can be left as it is, because the tool already requests the necessary rights, even when launched via the .desktop file that runs "boot-repair" making it is less obvious that rights are indeed requested.