Comment 16 for bug 806291

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote : Re: [needs-packaging] Boot-Repair

Hi,

Given that Debian version won't be ready on-time for Precise, would it be possible to upload it to Ubuntu and then sync back from Debian?
Any Archive admin volunteers to review it if it got uploaded?

Reviewing it myself, I found the following 'flows' in the package/app:
- desktop-file-validategives the following error: "boot-repair.desktop: error: value "3.08" for key "Version" in group "Desktop Entry" is not a known version" on both .desktop files
- copyright file should name the files with his path for the MIT license (usr/share/boot-sav/bis*.sh)
- the same for glade2script.py (usr/share/boot-sav/glade2script.py)
- When launching boot-repair, I'm getting a popup stating that there is a newer version of boot-repair that I should download or use boot-repair-disk. I think this popup should be disabled for Debian/Ubuntu via a distro specific patch.
- it installed syslinux and parted when launched. Shouldn't that be a Depends in the boot-repair package (control file) as this seems quite mandatory to have them?
- I've got the feeling that boot-repair have ot be launched as root. Is it the case? If so, you should use gksudo or equivalent in the .desktop files
- I ran cleanupubiquitybefore by error, and I got lucky because I wasn't logged in as root, otherwise I would have deleted all my system. Is it really the intention? If so, it should be clearly stated in the description and if possible, add a warning at the beginning of the script.

Thanks,
Fabrice