[needs-packaging] opengcs

[Balint Reczey]

 Description : Guest Compute Service for Linux Hyper-V Container
 Open Guest Compute Service is a Linux-based open source project to
 further the development of a production quality implementation of
 Linux Hyper-V container on Microsoft Windows (LCOW).
 It's designed to run inside a custom Linux OS for supporting Linux
 container payload.

URL : https://github.com/Microsoft/opengcs
License : MIT

Please accept opengcs package to the Ubuntu archive. It is also uploaded to Debian but is stuck in Debian's NEW queue for ~1 month.
When is gets accepted to Debian it can be synced.

[Brian Murray (brian-murray)]

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

[Łukasz Zemczak (sil2100)]

Hello Balint! I was looking at your package from the NEW POV (as part of training) and I have some questions/potential things that might be good to fix. This is not yet a formal review, I guess someone more experienced might follow up and do a full review.

First of all, the debian/copyright file needs to be updated as it's pointing to the vendor/github.com/docker/ directory which does not exist in the current repackaged tarball. Please change this accordingly. The README.source could be modified to make it clear why it made sense to repackage the tarball. Currently it only mentions the fact that we need to ship the containerd and docker newer versions - but that can't be the only reason as those are anyway shipped already by the upstream tarball in the vendor directory (so for this reason repackaging makes no sense). I guess you're repackaging the tarball to remove all the other unnecessary vendor-shipped packages, right? If that's the case, that needs to be stated in the README.source.

From smaller things I see that the debian/rules mentions xenial already, although we should basically care about bionic right now (those things can be introduced as a delta to xenial, or not mentioned at all).

[Łukasz Zemczak (sil2100)]

Ok, I checked the latest version of opengcs in the NEW queue and it looks much better. The repacking is unfortunate, but I understand the rationale and approve of it (especially that now it's well explained in the README.source file).

From my POV it's a +1 on including this into universe. But I'll leave the final decision to someone in ubuntu-archive with more experience. Once someone else approves I'll accept it.

[Matthias Klose (doko)]

ftbfs on 32bit archs