root folder of filelist has wrong sharesize

Bug #919355 reported by iceman50
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Confirmed
Low
Unassigned

Bug Description

When opening my own filelist the root directory shows a larger sharesize than what is reported by ShareManager::getShareSize()

Tags: core
eMTee (realprogger)
Changed in dcplusplus:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Fredrik Ullner (ullner) wrote :

getShareSize ignores duplicate files. The file list size, I presume, includes duplicates. Therefore, the funtionality you are seeing is actually the intended behaviour.

There are two things that can be done; 1) mark this report as invalid (though, possibly adding information in the help file) or 2) make sure that duplicates are included in the size. Or, possibly, 3) have one label stating unique share size and one stating total share size.

Revision history for this message
iceman50 (bdcdevel) wrote :

Option number 3 seems to be the best ... maybe something like "Sharesize: ## (including dupes: ##)"

Revision history for this message
poy (poy) wrote :

#3 sounds good but it would A) require caching (file lists are sensitive to performance) and B) be confusing for most people. it is the best option in my eyes, but has to be done right.

Fredrik Ullner (ullner)
tags: added: core
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.