Tab closure on mouse down

[Robert K]

Closure of a tab is done with middle mouse button on "mouse down". Most other applications with tabs close them on "mouse up" and it 'feels' better that way IMO.

[Szabolcs Molnár (fleet)]

Now that you mentioned, I tried it with some random tabbed applications (Chrome, Firefox, Notepad++), and you're right. They really work that way, so I support the change in DC++ too.

[iceman50 (bdcdevel)]

Made a small patch to change =)

[poy (poy)]

good start. :) but this will need an additional verification to make sure that the tab that received the "mouse down" event is the same as the one on "mouse up". eg i start middle-clicking on tab1, then drag the mouse to tab2; no tab should be closed in that case.

what about shift + left-click? should that also be changed to take effect only after the mouse has been released?

[Szabolcs Molnár (fleet)]

"what about shift + left-click? should that also be changed to take effect only after the mouse has been released?"

Probably yes

[iceman50 (bdcdevel)]

I think that would probably be the best way, I was actually thinking about that to myself (in regards to making sure that the tab that receives the mouse click event is the tab that gets it)

[poy (poy)]

in rev 2660.

[poy (poy)]

Fixed in DC++ 0.790.