[Request] Only generate entry for fully completed downloads in the log file

Bug #710359 reported by LoRenZo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Low
Unassigned

Bug Description

I would like to use the download logging feature, but only if the unneccessary parts are skipped.
For example, a file with 300MB size can generate about 100 entries in the log if the download speed is to slow (small segments are generated for slow speed).
In my opinion, 1 entry would be sufficent when the file has been completely downloaded; or at least an option for this setting.

Revision history for this message
eMTee (realprogger) wrote :

Here's the patch to test, with the very basic parameters what could easily be gathered. The rest of the parameters that available for chunks only either impossible to get / totally different or needs a lot more work, so this patch provides a basic logging functionality for finished downloads (as well as clarifying the name of some logging options).

Changed in dcplusplus:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
eMTee (realprogger) wrote :

Here is a patch proposal for a full featured finished downloads log...

Revision history for this message
poy (poy) wrote :

looking good, please attend to the following then commit:
- are logs ok when DC++ is shut down / restarted during a DL (especially the "actual" value)?
- how about logging file list transfers?
- "HintedUserList::const_iterator i;" that line is useless.
- change (*i).user to i->user.
- run ip = _("Offline"); only when no ip was found (ip.empty()).
- params["speed"] should be translatable ("%1%/s").

Revision history for this message
eMTee (realprogger) wrote :

- are logs ok when DC++ is shut down / restarted during a DL (especially the "actual" value)?
Yes. Just as the FInished window, it collects the session only data and shows the session actual size for "actual" as like before in the non-segmented days.

The filelist logging not touched, stayed in the chunks log, as it was before. The logFinishedDownload function isn't called for filelists.

eMTee (realprogger)
Changed in dcplusplus:
status: Confirmed → Fix Committed
Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.790.

Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.