[0.770] Compilation error on Linux

Bug #603071 reported by netcelli-tux
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Undecided
Unassigned

Bug Description

Last core doesn't compile on Linux.

In class FindFileIter, DirData structure has no member called ent and base. Then declaration of != operator is wrong.

Also there are some errors related to std::tr1 members; changing header inclusion in stdinc.h fixes this.

I have attached 3 patches that fix File.h, File.cpp and stdinc.h

Revision history for this message
lys (lys) wrote :

which rev no? cause this wont apply against the current core

Revision history for this message
lys (lys) wrote :

K7 root # bzr branch lp:dcplusplus
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data. See "bzr help launchpad-login".
Branched 2177 revision(s).
K7 root # cp -R dcplusplus/dcpp /root/
K7 root # patch -p1 < File.cpp.diff
patching file dcpp/File.cpp
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file dcpp/File.cpp.rej

tried all 3 and none of them apply this end :-/

Revision history for this message
netcelli-tux (netcelli-tux) wrote :

I'm sorry! I did wrong patch files. Attached the correct ones.

netcelli $ bzr branch lp:dcplusplus dcplusplus
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data. See "bzr help launchpad-login".
Branched 2177 revision(s).

netcelli $ cd dcplusplus
netcelli ~/dcplusplus $ patch -p0 -i ../File.cpp.patch
patching file dcpp/File.cpp
netcelli ~/dcplusplus $ patch -p0 -i ../File.h.patch
patching file dcpp/File.h
netcelli@amd ~dcplusplus $ patch -p0 -i ../stdinc.patch
patching file dcpp/stdinc.h

Revision history for this message
netcelli-tux (netcelli-tux) wrote :
Revision history for this message
netcelli-tux (netcelli-tux) wrote :
Revision history for this message
Tehnick (tehnick) wrote :

In file File.h must be:
+ struct dirent* ent;
on my opinion.

Revision history for this message
netcelli-tux (netcelli-tux) wrote :

You are right.

Revision history for this message
poy (poy) wrote :

applied the 2 File patches but not the struct direct change, this is C++ not C. ;)

Changed in dcplusplus:
status: New → Fix Committed
Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.780.

Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.