After filelist download DC++ tries to do a folder move operation in some cases

[eMTee]

--Converted from a question--

Since the latest dc++ update (0.761) I'm no more able to load file lists with the correct file path (like when you are right-clicking on a file in the search tab and choose to load the file list).
Instead it switches to the root directory and gives following error message in the system protocol:

Unable to move <Remote path shown in the Path coloumn in the search listview> to <C:\Users\MyComputername\AppData\Local\DC++\FileLists\NickOfTheUser.CID> (The system cannot find the path specified.) nor to rename to <Remote path shown in the Path coloumn in the search listview\NickOfTheUser.CID> (The system cannot find the path specified.)

This problem only occured with the recent version of dc++, not before. I'm running Windows 7 Professional 64Bit, logged in as administrator.

[eMTee (realprogger)]

Steps to reproduce
1. Get a filelist from search results
2. Make the downloaded file inaccessible (open exclusively with another program)
3. Close the filelist tab
4. Get the filelist again

I can't reproduce this when getting the filelist from a hub's userlist.

Problem is that if the remote path is coincidently exists locally (absolute or relative) it can trigger an unneeded move operation of a complete local folder...

[eMTee (realprogger)]

Now at second try, it always happens to me when I get a filelist from search results, no need to lock the filelist path. Currently many users reporting problems opening filelists or "Get file list function in search result no longer navigates to location of file/directory again", maybe this is the root of their problems...

[eMTee (realprogger)]

Ignore comment #1, the problem happens only when a filelist downloaded from searches and is because of a change in QueueManager line 1131 in rev1935.

A file is moved when the finished queue item's tempTarget property is not empty or its finished. This property is usually empty for filelists, but not in the case above, there it is used to store the path of where should the filelist be positioned when its opened in the GUI. The attached patch restricts move operation only to downloaded files.

The patch does not solve the original problem in related question, another bug has already been opened for that...

[poy (poy)]

i can't really judge this but the change seems simple enough, so if it works it can be added. these spurious file move failures have been annoying me too.

[poy (poy)]

Fixed in version 0.762.