Nick and description limit is set to 35 characters

[Tha Jsta]

The description field located in personal information in the settings pannel only lets you type 35 characters. I can't even type a full blog URL because of this. Limiting the description at at least 100 characters is sufficient.

Operating System: Windows XP Service Pack 3
DC++ Version: 0.7.5.0

[Fredrik Ullner (ullner)]

I've commited the necessary changes to bzr; there is no limit now on nicks or descriptions.

Fun facts: I raised this issue in March 2007 where arne agreed 'if it bothered me enough to fix it myself'. In January 2008, I raised the issue again, unknowingly (apparantly) I had a) raised the issue once before and b) I had half-committed myself into fixing it. August 2009 (i.e. today), I finally submitted the fix, after venting that I had (mis)remembered that NMDC had this as a protocol restriction (which it hadn't, for all I could see), and instead was shown that I had already talked about this, not once, but twice, before.

[Tha Jsta (thajsta)]

I am blind. Do you know if you could make it more keyboard accessible
since I can't see to use a mouse?

On 24/08/2009, Fredrik Ullner <email address hidden> wrote:
> I've commited the necessary changes to bzr; there is no limit now on
> nicks or descriptions.
>
> Fun facts: I raised this issue in March 2007 where arne agreed 'if it
> bothered me enough to fix it myself'. In January 2008, I raised the
> issue again, unknowingly (apparantly) I had a) raised the issue once
> before and b) I had half-committed myself into fixing it. August 2009
> (i.e. today), I finally submitted the fix, after venting that I had
> (mis)remembered that NMDC had this as a protocol restriction (which it
> hadn't, for all I could see), and instead was shown that I had already
> talked about this, not once, but twice, before.
>
> ** Changed in: dcplusplus
> Importance: Undecided => Wishlist
>
> ** Changed in: dcplusplus
> Status: New => Fix Committed
>
> ** Summary changed:
>
> - The description field located in personal information in the settings
> pannel only lets you type 35 characters. I can't even type a full blog URL
> because of this. Limiting the description at at least 100 characters is
> sufficient.
> + Nick and description limit is set to 35 characters
>
> ** Description changed:
>
> + The description field located in personal information in the settings
> + pannel only lets you type 35 characters. I can't even type a full blog
> + URL because of this. Limiting the description at at least 100 characters
> + is sufficient.
> +
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Fredrik Ullner (ullner)]

While that should be a completely different request (in case there isn't one already or if it isn't in progress), you can visit http://gutterstar.net/dc_plus_plus_scripts.php for a potential remedy. I have no idea if it's a) malware free, b) accurate, c) easy to use, d) up to date. Also, it's not an official DC++ page and I have no affiliation with it.

[Tha Jsta (thajsta)]

Is the version you fixed posted? I see 0.75 but no new one.

On 24/08/2009, Fredrik Ullner <email address hidden> wrote:
> While that should be a completely different request (in case there isn't
> one already or if it isn't in progress), you can visit
> http://gutterstar.net/dc_plus_plus_scripts.php for a potential remedy. I
> have no idea if it's a) malware free, b) accurate, c) easy to use, d) up
> to date. Also, it's not an official DC++ page and I have no affiliation
> with it.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Fredrik Ullner (ullner)]

There is not an official version out with solely my commit; multiple bug fixes and features are added together before an official version is released. This is only interesting for you if you are able to compile DC++ yourself. In other words, you need to wait for the new version to appear, whenever that may be (I have no idea when that'll be).

[Gabberworld (gabberworld)]

NMDC protocol limits.

nick : 25 chars
Email : 25 chars
Description: 35 chars

if you change them then you break protocol.

[Tha Jsta (thajsta)]

Somebody e-mailed me saying he had fixed this though. So when the next
release comes out, this should be fixed.

On 29/08/2009, Gabberworld <email address hidden> wrote:
> NMDC protocol limits.
>
> nick : 25 chars
> Email : 25 chars
> Description: 35 chars
>
> if you change them then you break protocol.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[cologic (cologic)]

Gabberworld, can you provide external documentation or evidence for your statement?

[Tha Jsta (thajsta)]

I wouldn't mind knowing either. I'm not a software programmer, but if
somebody can do it then it can be done.

On 29/08/2009, cologic <email address hidden> wrote:
> Gabberworld, can you provide external documentation or evidence for your
> statement?
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Gabberworld (gabberworld)]

evidence you can get from NeoModus Direct Connect client what is creator for NMDC protocol, install that and then look how many chars you can add to settings.

official web is dead long time now soo no point go there :) google is your friend.

[Tha Jsta (thajsta)]

But isn't DC++ an improved version of the original DC client?
Shouldn't this mean that you can improve upon that including this?

On 29/08/2009, Gabberworld <email address hidden> wrote:
> evidence you can get from NeoModus Direct Connect client what is creator
> for NMDC protocol, install that and then look how many chars you can add
> to settings.
>
> official web is dead long time now soo no point go there :) google is
> your friend.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Gabberworld (gabberworld)]

i not really care what DC++ makes but with this new change hubs start use more memory and connection upload speed start suffer allot, that means less users in hub's or more hub owners start disable user description in hub settings.

in nmdc is $MyINFO already big enoh and this new change makes that even worse.

[Fredrik Ullner (ullner)]

Gabberworld: Having or not an artificial restriction in the client shouldn't affect how the protocol works, and in fact this does not. If hubs haven't protected themselves from this, well, then, they're stupid implementations. There is nothing that have stopped people in the past to a) send a user command (in DC++ no less), b) write their own client or c) modified DC++ to remove the limit themselves. You have never been able to predict the size of the MyINFO. (While you may argue that some hubs will start to crash now because of malicious users, but that's silly; they could've done this perfectly fine in the past. Plus, I doubt these people use DC++ and not some clone.)

[poy (poy)]

the reference to be used shouldn't be the original NMDC client program, but the original NMDC hub program; and as far as i can remember, it didn't choke on long nicks, in fact it even had a message that went like "Nick too long".

[Tha Jsta (thajsta)]

I cannot even write my full blog URL due to the 35 character limit,
and that's why I want it at least 50 characters.

On 30/08/2009, poy <[e-mail]> wrote:
> the reference to be used shouldn't be the original NMDC client program,
> but the original NMDC hub program; and as far as i can remember, it
> didn't choke on long nicks, in fact it even had a message that went like
> "Nick too long".
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Gabberworld (gabberworld)]

i have better solution for that.

add 85 char limit for nick, Email and Description.

that way user can choose where it add those chars, if nick name is long then less chars you can add Email and Description...

this way you not really fuckup $MyINFO size.

[Tha Jsta (thajsta)]

85 is good. All's I want is enough space to type a URL in the
description. Whatever happens, I'm sure it will be fixed in the next
stable release of DC++.

On 30/08/2009, Gabberworld <email address hidden> wrote:
> i have better solution for that.
>
> add 85 char limit for nick, Email and Description.
>
> that way user can choose where it add those chars, if nick name is long
> then less chars you can add Email and Description...
>
> this way you not really fuckup $MyINFO size.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[cologic (cologic)]

Gabberworld: if a hub administrator wants to enforce some constraint, let him enforce it the only place he can really trust: his own hub software. The client, in general, cannot assumed to be trustworthy, and any security model (in this case, against abusively long nicks, emails, and descriptions) that depends on such a client-enforced constraint is not merely pointless but counterproductive because it encourages hub administrators to react precisely as you're doing here by blaming clients for their own hubs' failures.

[Tha Jsta (thajsta)]

So just make it simple and remove any limit in the client. Then there
won't be conversation at all.

On 30/08/2009, cologic <email address hidden> wrote:
> Gabberworld: if a hub administrator wants to enforce some constraint,
> let him enforce it the only place he can really trust: his own hub
> software. The client, in general, cannot assumed to be trustworthy, and
> any security model (in this case, against abusively long nicks, emails,
> and descriptions) that depends on such a client-enforced constraint is
> not merely pointless but counterproductive because it encourages hub
> administrators to react precisely as you're doing here by blaming
> clients for their own hubs' failures.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[cologic (cologic)]

That's what Fredrik Ullner's patch at http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/revision/1819 does. As far as I can tell, none of the the patches since have undone his change.

[Tha Jsta (thajsta)]

Yea, that's the homie that first replied to my bug report. I didn't
think he posted a patch; I thought it was gonna be included in the
next release. But thanks, I'll check out the patch.

On 30/08/2009, cologic <email address hidden> wrote:
> That's what Fredrik Ullner's patch at http://bazaar.launchpad.net
> /~dcplusplus-team/dcplusplus/trunk/revision/1819 does. As far as I can
> tell, none of the the patches since have undone his change.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Tha Jsta (thajsta)]

I went to the URL and it said it isn't found.

On 30/08/2009, cologic <email address hidden> wrote:
> That's what Fredrik Ullner's patch at http://bazaar.launchpad.net
> /~dcplusplus-team/dcplusplus/trunk/revision/1819 does. As far as I can
> tell, none of the the patches since have undone his change.
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Gabberworld (gabberworld)]

intresting text you typed coloric,

to you want say that i should not trust DC++ what is mother for DC right now?

and i don't blame here. hubsoft's self can handle data if there is no limit in client.

question is can hardware handle them, like i tell there fill be more memory usage more internet connection needed for both site.

and if there is no limit then how you tell how powerfull server/PC you need use for all that data what comes in and starts go out?

limits are made for reason not made for somesort pointles feature.

to you realy think that users start like if protocol self eat all internet connection speed.

[cologic (cologic)]

Tha Jsta, I'll try putting the URL on its own line (it works fine for me now though - just click on it rather than trying to select it or anything else):
http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/revision/1819

Gabberworld: My name in these forums is "cologic", not "coloric". Now whom might you be referring to?

[Tha Jsta (thajsta)]

Do I download two files and put them in the \Program Files\DC++
directory then? It works now.

On 30/08/2009, cologic <email address hidden> wrote:
> Tha Jsta, I'll try putting the URL on its own line (it works fine for me now
> though - just click on it rather than trying to select it or anything else):
> http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/revision/1819
>
> Gabberworld: My name in these forums is "cologic", not "coloric". Now
> whom might you be referring to?
>
> --
> Nick and description limit is set to 35 characters
> https://bugs.launchpad.net/bugs/414068
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in DC++: Fix Committed
>
> Bug description:
> The description field located in personal information in the settings pannel
> only lets you type 35 characters. I can't even type a full blog URL because
> of this. Limiting the description at at least 100 characters is sufficient.
>
> Operating System: Windows XP Service Pack 3
> DC++ Version: 0.7.5.0
>

[Gabberworld (gabberworld)]

just remember any change what you make in DC++ affects all users in DC. soo 10 times think and one time make.

[cologic (cologic)]

Tha Jsta: It'll be fixed in the next DC++ version.

Gabberworld: If one wants to apply some arbitrary constraints to nicks, emails, and descriptions, one is free as a hub administrator to do so. If one limits them all to 35 characters, the bandwidth usage of the hub should be exactly the same as it is today, modulo some clients sending a slightly larger $MyINFO the hub has to edit. But since broadcasts form the bulk of a hub's bandwidth usage and hubs are perfectly capable of truncating or rejecting nicks, emails, and descriptions which violate any rules they might contain, hubs are under no obligation to send larger DC messages than today. I'm not disputing the utility of limits, I'm disputing the utility of relying on clients to enforce limits.

[poy (poy)]

Fixed in version 0.760.