Bloom filter does not match spec

[Quicksilver]

It seems like the Bloomfilter in DC++ does not match the spec of the extension given.

I added a Test Vector section in the wiki http://www.adcportal.com/wiki/index.php/BLOM where I tried to give a reference of what I understood by the description of the Bloomfilter in the spec.

Would be nice if DC++ could implement the described bloomfilter and not just "some" bloomfilter.

[Quicksilver (christianortolf)]

So the test Vectors don't get lost somehow.. I attached them here.

These testvectors were created with the jucy implementation (and will be advertised with jucy Version 0.77 as BLO1 to not collide with current BLO0 implementation of DC++).

[poy (poy)]

added a testing tool in rev 3053: <http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/test/testbloom.cpp>

the only test that doesn't pass is the last one:
  Actual: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAI
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
Expected: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"

if you feel like fixing it, the implementation is in the HashBloom class: <http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/dcpp/HashBloom.cpp>

[poy (poy)]

fixed thanks to <http://www.dcbase.org/forums/viewtopic.php?f=18&t=787>.

[poy (poy)]

Fixed in DC++ 0.802.