Bloom filter does not match spec

Bug #411484 reported by Quicksilver on 2009-08-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Undecided
Unassigned

Bug Description

It seems like the Bloomfilter in DC++ does not match the spec of the extension given.

I added a Test Vector section in the wiki http://www.adcportal.com/wiki/index.php/BLOM where I tried to give a reference of what I understood by the description of the Bloomfilter in the spec.

Would be nice if DC++ could implement the described bloomfilter and not just "some" bloomfilter.

Quicksilver (christianortolf) wrote :

So the test Vectors don't get lost somehow.. I attached them here.

These testvectors were created with the jucy implementation (and will be advertised with jucy Version 0.77 as BLO1 to not collide with current BLO0 implementation of DC++).

poy (poy) wrote :

added a testing tool in rev 3053: <http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/test/testbloom.cpp>

the only test that doesn't pass is the last one:
  Actual: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAI
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"
Expected: "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"

if you feel like fixing it, the implementation is in the HashBloom class: <http://bazaar.launchpad.net/~dcplusplus-team/dcplusplus/trunk/view/head:/dcpp/HashBloom.cpp>

poy (poy) wrote :
Changed in dcplusplus:
status: New → Fix Committed
poy (poy) wrote :

Fixed in DC++ 0.802.

Changed in dcplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers